Source/web/ContextMenuClientImpl.cpp - Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index d1b49209c74095ab4657ae1c94ad65b1ed610740..317c71287a6133a4012288d93c6a2cec4f9de80f 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -159,7 +159,7 @@ static String selectMisspellingAsync(LocalFrame* selectedFrame, DocumentMarker&

// Caret and range selections always return valid normalized ranges.

RefPtrWillBeRawPtr<Range> selectionRange = selection.toNormalizedRange();

- Vector<DocumentMarker*> markers = selectedFrame->document()->markers().markersInRange(selectionRange.get(), DocumentMarker::MisspellingMarkers());

+ WillBeHeapVector<DocumentMarker*> markers = selectedFrame->document()->markers().markersInRange(selectionRange.get(), DocumentMarker::MisspellingMarkers());

if (markers.size() != 1)

return String();

marker = *markers[0];

« no previous file with comments | « Source/platform/geometry/IntRect.h ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »