Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: src/interpreter/interpreter-intrinsics-generator.cc

Issue 2893223002: [Interpreter] No need to read/return a value in GeneratorClose. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter-intrinsics-generator.cc
diff --git a/src/interpreter/interpreter-intrinsics-generator.cc b/src/interpreter/interpreter-intrinsics-generator.cc
index e8572ba1d4fb39faa2e62acb7dc4a1ec1ab72790..1f2816d2dbbc29908543028a1b89297c7cc59cae 100644
--- a/src/interpreter/interpreter-intrinsics-generator.cc
+++ b/src/interpreter/interpreter-intrinsics-generator.cc
@@ -437,13 +437,10 @@ Node* IntrinsicsGenerator::GeneratorGetResumeMode(Node* args_reg,
Node* IntrinsicsGenerator::GeneratorClose(Node* args_reg, Node* arg_count,
Node* context) {
Node* generator = __ LoadRegister(args_reg);
- Node* const value =
- __ LoadObjectField(generator, JSGeneratorObject::kResumeModeOffset);
__ StoreObjectFieldNoWriteBarrier(
generator, JSGeneratorObject::kContinuationOffset,
__ SmiConstant(JSGeneratorObject::kGeneratorClosed));
-
- return value;
+ return __ UndefinedConstant();
}
Node* IntrinsicsGenerator::AsyncGeneratorReject(Node* input, Node* arg_count,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698