chrome/browser/subresource_filter/subresource_filter_browsertest.cc - Issue 2893183002: [subresource_filter] Use the SubresourceFilterObserver for PageLoadMetrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

Issue 2893183002: [subresource_filter] Use the SubresourceFilterObserver for PageLoadMetrics (Closed)

Patch Set: fix optional decl Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

diff --git a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

index 57cae1fd5e0af13febdcd2e1d401734a7f809b49..298d491c4420bf3e203dcd8935430497beeb2b19 100644

--- a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

+++ b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

@@ -1280,7 +1280,7 @@ IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,

}

IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,

- WhiteliseSiteOnReload_ActivationDisabledOnReload) {

+ WhitelistSiteOnReload_ActivationDisabledOnReload) {

GURL url(GetTestUrl("subresource_filter/frame_with_included_script.html"));

ConfigureAsPhishingURL(url);

ASSERT_NO_FATAL_FAILURE(

@@ -1316,7 +1316,7 @@ IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,

IN_PROC_BROWSER_TEST_F(

SubresourceFilterBrowserTest,

- WhiteliseSiteOnReload_ActivationDisabledOnReloadFromScript) {

+ WhitelistSiteOnReload_ActivationDisabledOnReloadFromScript) {

GURL url(GetTestUrl("subresource_filter/frame_with_included_script.html"));

ConfigureAsPhishingURL(url);

ASSERT_NO_FATAL_FAILURE(

@@ -1354,7 +1354,7 @@ IN_PROC_BROWSER_TEST_F(

IN_PROC_BROWSER_TEST_F(

SubresourceFilterBrowserTest,

- WhiteliseSiteOnReload_ActivationDisabledOnNavigationToSameURL) {

+ WhitelistSiteOnReload_ActivationDisabledOnNavigationToSameURL) {

GURL url(GetTestUrl("subresource_filter/frame_with_included_script.html"));

ConfigureAsPhishingURL(url);

ASSERT_NO_FATAL_FAILURE(