Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h

Issue 2893183002: [subresource_filter] Use the SubresourceFilterObserver for PageLoadMetrics (Closed)
Patch Set: fix optional decl Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
index b0c9e322eac6411afd99b6df77c4d9753e133a16..1fc0ea811899383c156171e105da6cf82878fe4c 100644
--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
@@ -6,7 +6,11 @@
#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_SUBRESOURCE_FILTER_METRICS_OBSERVER_H_
#include "base/macros.h"
+#include "base/optional.h"
+#include "base/scoped_observer.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "components/subresource_filter/content/browser/subresource_filter_observer.h"
+#include "components/subresource_filter/content/browser/subresource_filter_observer_manager.h"
namespace internal {
@@ -58,12 +62,16 @@ extern const char kHistogramSubresourceFilterActivationDecisionReload[];
} // namespace internal
class SubresourceFilterMetricsObserver
- : public page_load_metrics::PageLoadMetricsObserver {
+ : public page_load_metrics::PageLoadMetricsObserver,
+ public subresource_filter::SubresourceFilterObserver {
public:
- SubresourceFilterMetricsObserver() = default;
- ~SubresourceFilterMetricsObserver() override = default;
+ SubresourceFilterMetricsObserver();
+ ~SubresourceFilterMetricsObserver() override;
// page_load_metrics::PageLoadMetricsObserver:
+ ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
+ const GURL& currently_committed_url,
+ bool started_in_foreground) override;
ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
ObservePolicy FlushMetricsOnAppEnterBackground(
const page_load_metrics::mojom::PageLoadTiming& timing,
@@ -93,10 +101,22 @@ class SubresourceFilterMetricsObserver
bool is_in_main_frame) override;
private:
+ // subresource_filter::SubresourceFilterObserver:
+ void OnPageActivationComputed(
+ content::NavigationHandle* navigation_handle,
+ subresource_filter::ActivationDecision activation_decision,
+ const subresource_filter::ActivationState& activation_state) override;
+
void OnGoingAway(const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info,
base::TimeTicks app_background_time);
+ base::Optional<subresource_filter::ActivationDecision> activation_decision_;
+
+ ScopedObserver<subresource_filter::SubresourceFilterObserverManager,
+ subresource_filter::SubresourceFilterObserver>
+ scoped_observer_;
+
int64_t network_bytes_ = 0;
int64_t cache_bytes_ = 0;

Powered by Google App Engine
This is Rietveld 408576698