components/subresource_filter/content/browser/subresource_filter_observer.h - Issue 2893183002: [subresource_filter] Use the SubresourceFilterObserver for PageLoadMetrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/subresource_filter_observer.h

Issue 2893183002: [subresource_filter] Use the SubresourceFilterObserver for PageLoadMetrics (Closed)

Patch Set: bmcquade review Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc ('K') | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/subresource_filter_observer.h

diff --git a/components/subresource_filter/content/browser/subresource_filter_observer.h b/components/subresource_filter/content/browser/subresource_filter_observer.h

index 7daa78a65f738e5091ba17188001a11bbfaa9e77..21a226edc42a314d8b47c668a162c2ae3d081191 100644

--- a/components/subresource_filter/content/browser/subresource_filter_observer.h

+++ b/components/subresource_filter/content/browser/subresource_filter_observer.h

@@ -21,8 +21,12 @@ class SubresourceFilterObserver {

public:

virtual ~SubresourceFilterObserver() = default;

+ // Called before the observer manager is destroyed. Observers must unregister

+ // themselves by this point.

virtual void OnSubresourceFilterGoingAway() {}

+ // Called at most once per navigation when page activation is computed. This

+ // will be called before ReadyToCommitNavigation.

virtual void OnPageActivationComputed(

content::NavigationHandle* navigation_handle,

ActivationDecision activation_decision,