Add SimpleGeolocationTest unit test.

chrome/browser/chromeos/geolocation/simple_geolocation_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/geolocation/simple_geolocation_request.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/json/json_reader.h"
@@ skipping 187 matching lines @@
 
   if (error_object) {
     if (!error_object->GetStringWithoutPathExpansion(
             kMessageString, &(position->error_message))) {
       position->error_message = "Server returned error without message.";
     }
 
     // Ignore result (code defaults to zero).
     error_object->GetIntegerWithoutPathExpansion(kCodeString,
                                                  &(position->error_code));
+  } else {
+    position->error_message.erase();
   }
 
   if (location_object) {
     if (!location_object->GetDoubleWithoutPathExpansion(
             kLatString, &(position->latitude))) {
       PrintGeolocationError(server_url, "Missing 'lat' attribute.", position);
       RecordUmaEvent(SIMPLE_GEOLOCATION_REQUEST_EVENT_RESPONSE_MALFORMED);
       return false;
     }
     if (!location_object->GetDoubleWithoutPathExpansion(
@@ skipping 47 matching lines @@
 }
 
 }  // namespace
 
 SimpleGeolocationRequest::SimpleGeolocationRequest(
     net::URLRequestContextGetter* url_context_getter,
     const GURL& service_url,
     base::TimeDelta timeout)
     : url_context_getter_(url_context_getter),
       service_url_(service_url),
+      retry_sleep_on_server_error_(base::TimeDelta::FromSeconds(
+          kResolveGeolocationRetrySleepOnServerErrorSeconds)),
+      retry_sleep_on_bad_response_(base::TimeDelta::FromSeconds(
+          kResolveGeolocationRetrySleepBadResponseSeconds)),
       timeout_(timeout),
       retries_(0) {
 }
 
 SimpleGeolocationRequest::~SimpleGeolocationRequest() {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   // If callback is not empty, request is cancelled.
   if (!callback_.is_null()) {
     RecordUmaResponseTime(base::Time::Now() - request_started_at_, false);
@@ skipping 22 matching lines @@
 void SimpleGeolocationRequest::MakeRequest(const ResponseCallback& callback) {
   callback_ = callback;
   request_url_ = GeolocationRequestURL(service_url_);
   timeout_timer_.Start(
       FROM_HERE, timeout_, this, &SimpleGeolocationRequest::OnTimeout);
   request_started_at_ = base::Time::Now();
   StartRequest();
 }
 
 void SimpleGeolocationRequest::Retry(bool server_error) {
-  const base::TimeDelta delay = base::TimeDelta::FromSeconds(
-      server_error ? kResolveGeolocationRetrySleepOnServerErrorSeconds
-                   : kResolveGeolocationRetrySleepBadResponseSeconds);
+  base::TimeDelta delay(server_error ? retry_sleep_on_server_error_
+                                     : retry_sleep_on_bad_response_);
   request_scheduled_.Start(
       FROM_HERE, delay, this, &SimpleGeolocationRequest::StartRequest);
 }
 
 void SimpleGeolocationRequest::OnURLFetchComplete(
     const net::URLFetcher* source) {
   DCHECK_EQ(url_fetcher_.get(), source);
 
   net::URLRequestStatus status = source->GetStatus();
   int response_code = source->GetResponseCode();
@@ skipping 48 matching lines @@
            ? SIMPLE_GEOLOCATION_REQUEST_RESULT_SERVER_ERROR
            : SIMPLE_GEOLOCATION_REQUEST_RESULT_FAILURE);
   RecordUmaResult(result, retries_);
   position_.status = Geoposition::STATUS_TIMEOUT;
   const base::TimeDelta elapsed = base::Time::Now() - request_started_at_;
   ReplyAndDestroySelf(elapsed, true /* server_error */);
   // "this" is already destroyed here.
 }
 
 }  // namespace chromeos