Add SimpleGeolocationTest unit test.

Add SimpleGeolocationTest unit test.

Add test for SimpleGeolocation.

BUG=245075
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271499

[Alexander Alekseev, 2014-05-19 14:57:59]

Please review.

[Nikita (slow), 2014-05-19 15:22:13]

https://codereview.chromium.org/289313005/diff/1/chrome/browser/chromeos/geol...
File chrome/browser/chromeos/geolocation/simple_geolocation_provider.h (right):

https://codereview.chromium.org/289313005/diff/1/chrome/browser/chromeos/geol...
chrome/browser/chromeos/geolocation/simple_geolocation_provider.h:43:
ScopedVector<SimpleGeolocationRequest>& get_requests_for_testing() {
Maybe male test friend instead?

https://codereview.chromium.org/289313005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc (right):

https://codereview.chromium.org/289313005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc:73:
EXPECT_GE(current_delay, base_retry_interval)
I don't think that this is a good idea to test this retry time interval in
unit_test. I believe PostDeleayedTask was never meant to be accurate enough for
you to test it here.

https://codereview.chromium.org/289313005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc:217:
EXPECT_EQ(4U, url_factory.num_attempts());
Why there were 4 attempts in case of response was fine?

[Alexander Alekseev, 2014-05-19 15:57:22]

https://codereview.chromium.org/289313005/diff/1/chrome/browser/chromeos/geol...
File chrome/browser/chromeos/geolocation/simple_geolocation_provider.h (right):

https://codereview.chromium.org/289313005/diff/1/chrome/browser/chromeos/geol...
chrome/browser/chromeos/geolocation/simple_geolocation_provider.h:43:
ScopedVector<SimpleGeolocationRequest>& get_requests_for_testing() {
On 2014/05/19 15:22:13, Nikita Kostylev wrote:
> Maybe male test friend instead?

Done.

https://codereview.chromium.org/289313005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc (right):

https://codereview.chromium.org/289313005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc:73:
EXPECT_GE(current_delay, base_retry_interval)
On 2014/05/19 15:22:13, Nikita Kostylev wrote:
> I don't think that this is a good idea to test this retry time interval in
> unit_test. I believe PostDeleayedTask was never meant to be accurate enough
for
> you to test it here.

I've removed delay checks here.

https://codereview.chromium.org/289313005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc:217:
EXPECT_EQ(4U, url_factory.num_attempts());
On 2014/05/19 15:22:13, Nikita Kostylev wrote:
> Why there were 4 attempts in case of response was fine?

Because 3 retry attempts were required in line 204.

[Nikita (slow), 2014-05-19 15:58:47]

https://codereview.chromium.org/289313005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc (right):

https://codereview.chromium.org/289313005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc:73:
EXPECT_GE(current_delay, base_retry_interval)
On 2014/05/19 15:57:23, alemate wrote:
> On 2014/05/19 15:22:13, Nikita Kostylev wrote:
> > I don't think that this is a good idea to test this retry time interval in
> > unit_test. I believe PostDeleayedTask was never meant to be accurate enough
> for
> > you to test it here.
> 
> I've removed delay checks here.

How about setting zero delays for tests?

[Nikita (slow), 2014-05-19 15:58:51]

lgtm

[Alexander Alekseev, 2014-05-19 17:21:58]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2014-05-19 17:22:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alemate@chromium.org/289313005/40001

[commit-bot: I haz the power, 2014-05-19 20:49:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-19 22:00:36]

Change committed as 271499