Chromium Code Reviews| Index: chrome/test/data/cld2_component/README.chromium |
| diff --git a/chrome/test/data/cld2_component/README.chromium b/chrome/test/data/cld2_component/README.chromium |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..9819846b2d1141d6449b6f06bb6e0593e20f9671 |
| --- /dev/null |
| +++ b/chrome/test/data/cld2_component/README.chromium |
| @@ -0,0 +1,25 @@ |
| +This directory contains a static copy of the contents of the CLD2 CRX file. |
| +The ID of the extension (as well as other relevant information) can be found |
| +in the following file: |
| + src/chrome/browser/component_updater/cld_component_installer.cc |
| + |
| +In general there should be little need to modify the data here. CLD2 updates |
| +are rare and consist of incremental improvements to language detection |
| +accuracy. All such updates are expected to be backwards-compatible from CLD2 |
| +revision 160 onwards, which is what the initial checkin her is in fact based |
|
rmcilroy
2014/05/19 13:16:02
nit - s/which is what the initial checkin her is i
|
| +upon. Any future format-breaking changes are likely to result in a "CLD3". |
| + |
| +For the sake of maintainability and clarity of purpose, the subdirectory that |
| +contains the CRX extract is named for the version that is contained within it. |
| +This mimics the behavior of the component updater and makes it obvious at a |
| +glance which version of the CRX is checked in here; if you DO update the |
| +content here, make sure to rename the directory and update the constant in the |
|
rmcilroy
2014/05/19 13:16:02
s/make sure to rename the directory/create a new d
|
| +test utilities class: |
| + src/chrome/browser/translate/translate_browser_test_utils.cc |
| + |
| +For more information about this directory and how to use it, contact the author: |
| + andrewhayden@chromium.org |
|
rmcilroy
2014/05/19 13:16:02
nit - I would drop this and add a "or contact some
|
| + |
| +for more information on CLD2, dynamic mode, and generating the data file see: |
|
rmcilroy
2014/05/19 13:16:02
/s/for/For
|
| + src/third_party/cld_2/README.chromium |
| + |