Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5110)

Unified Diff: chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Issue 2893053002: md-settings: wrap lock screen dialogs in dom-if. (Closed)
Patch Set: Fixed patch set 1 errors. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
diff --git a/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js b/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
index 9557b9d66edcac63a207f8b1adcacc5445bece5b..4b6864f6c5ab4d338812ed55fba4a902f090c567 100644
--- a/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
+++ b/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
@@ -305,8 +305,9 @@ cr.define('settings_people_page_quick_unlock', function() {
Polymer.dom.flush();
MockInteractions.tap(getFromElement('#setupPinButton'));
+ Polymer.dom.flush();
var setupPinDialog = getFromElement('#setupPin');
- assertTrue(setupPinDialog.$.dialog.open);
+ assertTrue(setupPinDialog.$$('#dialog').open);
assertEquals(1, fakeUma.getHistogramValue(
LockScreenProgress.CHOOSE_PIN_OR_PASSWORD));
});
@@ -337,8 +338,6 @@ cr.define('settings_people_page_quick_unlock', function() {
document.body.appendChild(element);
Polymer.dom.flush();
- element.open();
-
titleDiv = getFromElement('div[class="title"]');
problemDiv = getFromElement('#problemDiv');
pinKeyboard = getFromElement('pin-keyboard');
@@ -448,7 +447,7 @@ cr.define('settings_people_page_quick_unlock', function() {
// Hitting cancel at the setup step dismisses the dialog.
test('HittingBackButtonResetsState', function() {
MockInteractions.tap(backButton);
- assertFalse(element.$.dialog.open);
+ assertFalse(element.$$('#dialog').open);
});
// Hitting cancel at the confirm step dismisses the dialog.
@@ -456,7 +455,7 @@ cr.define('settings_people_page_quick_unlock', function() {
pinKeyboard.value = '1111';
MockInteractions.tap(continueButton);
MockInteractions.tap(backButton);
- assertFalse(element.$.dialog.open);
+ assertFalse(element.$$('#dialog').open);
});
// User has to re-enter PIN for confirm step.
« no previous file with comments | « chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698