Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: chrome/browser/resources/settings/people_page/lock_screen.js

Issue 2893053002: md-settings: wrap lock screen dialogs in dom-if. (Closed)
Patch Set: Fixed patch set 1 errors. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/lock_screen.js
diff --git a/chrome/browser/resources/settings/people_page/lock_screen.js b/chrome/browser/resources/settings/people_page/lock_screen.js
index fe5be029e66e86603bf7fd010986d95b6135aa97..ac2759d7f62ff03a5208d3b0a89c6d2b1d1ef941 100644
--- a/chrome/browser/resources/settings/people_page/lock_screen.js
+++ b/chrome/browser/resources/settings/people_page/lock_screen.js
@@ -123,6 +123,12 @@ Polymer({
type: Boolean,
value: false,
},
+
+ /** @private */
+ showPasswordPromptDialog_: Boolean,
+
+ /** @private */
+ showSetupPinDialog_: Boolean,
},
/** @private {?settings.EasyUnlockBrowserProxy} */
@@ -137,7 +143,7 @@ Polymer({
/** @override */
attached: function() {
if (this.shouldAskForPassword_(settings.getCurrentRoute()))
- this.$.passwordPrompt.open();
+ this.openPasswordPromptDialog_();
this.easyUnlockBrowserProxy_ =
settings.EasyUnlockBrowserProxyImpl.getInstance();
@@ -169,7 +175,7 @@ Polymer({
}
if (this.shouldAskForPassword_(newRoute)) {
- this.$.passwordPrompt.open();
+ this.openPasswordPromptDialog_();
} else if (newRoute != settings.Route.FINGERPRINT &&
oldRoute != settings.Route.FINGERPRINT) {
// If the user navigated away from the lock screen settings page they will
@@ -199,25 +205,37 @@ Polymer({
onSetModesChanged_: function() {
if (this.shouldAskForPassword_(settings.getCurrentRoute())) {
this.$.setupPin.close();
- this.$.passwordPrompt.open();
+ this.openPasswordPromptDialog_();
}
},
/** @private */
- onPasswordClosed_: function() {
+ openPasswordPromptDialog_: function() {
+ this.showPasswordPromptDialog_ = true;
+ },
+
+ /** @private */
+ onPasswordPromptDialogClose_: function() {
+ this.showPasswordPromptDialog_ = false;
if (!this.setModes_)
- settings.navigateTo(settings.Route.PEOPLE);
+ settings.navigateToPreviousRoute();
else
cr.ui.focusWithoutInk(assert(this.$$('#unlockType')));
},
- /** @private */
- onPinSetupDone_: function() {
- this.$.setupPin.close();
+ /**
+ * @param {!Event} e
+ * @private
+ */
+ onConfigurePin_: function(e) {
+ e.preventDefault();
+ this.writeUma_(LockScreenProgress.CHOOSE_PIN_OR_PASSWORD);
+ this.showSetupPinDialog_ = true;
},
/** @private */
- onSetupPinClosed_: function() {
+ onSetupPinDialogClose_: function() {
+ this.showSetupPinDialog_ = false;
cr.ui.focusWithoutInk(assert(this.$$('#setupPinButton')));
},
@@ -251,16 +269,6 @@ Polymer({
return this.i18n('lockScreenEditFingerprintsDescription');
},
- /**
- * @param {!Event} e
- * @private
- */
- onConfigurePin_: function(e) {
- e.preventDefault();
- this.$.setupPin.open();
- this.writeUma_(LockScreenProgress.CHOOSE_PIN_OR_PASSWORD);
- },
-
/** @private */
onEditFingerprints_: function() {
settings.navigateTo(settings.Route.FINGERPRINT);

Powered by Google App Engine
This is Rietveld 408576698