Chromium Code Reviews| Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.js |
| diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js |
| index bd4f1e7514b544c6468ca3b786c5148cc0d6f6c4..0760a623b25d3d9163211e3415f5efaaec5c5909 100644 |
| --- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js |
| +++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js |
| @@ -7,8 +7,7 @@ |
| * 'settings-setup-pin-dialog' is the settings page for choosing a PIN. |
| * |
| * Example: |
| - * |
| - * <settings-setup-pin-dialog set-modes="[[quickUnlockSetModes]]"> |
| + * * <settings-setup-pin-dialog set-modes="[[quickUnlockSetModes]]"> |
| * </settings-setup-pin-dialog> |
| */ |
| @@ -101,9 +100,6 @@ Polymer({ |
| /** @override */ |
| attached: function() { |
| this.resetState_(); |
| - }, |
| - |
| - open: function() { |
| this.$.dialog.showModal(); |
| this.$.pinKeyboard.focus(); |
|
dpapad
2017/06/01 17:48:44
Similar question about |autofocus| here. Can we ad
sammiequon
2017/06/01 20:21:10
Done.
|
| }, |
| @@ -276,7 +272,8 @@ Polymer({ |
| } |
| this.resetState_(); |
| - this.fire('done'); |
| + if (this.$.dialog.open) |
| + this.$.dialog.close(); |
| } |
| this.setModes.call( |