Issue 2892963002: Fix reparent on windows

Issue 2892963002: Fix reparent on windows (Closed)

Created:
3 years, 7 months ago by messick

Modified:
3 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -3 lines)			Patch
	M	pkg/analysis_server/lib/src/services/correction/assist_internal.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	pkg/analysis_server/test/services/correction/assist_test.dart	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download

Total messages: 8 (2 generated)

messick

I think this fixes the problem you mentioned but I can't really test it.

3 years, 7 months ago (2017-05-19 16:50:26 UTC) #2

Brian Wilkerson

lgtm You might be able to test it. We will use an end-of-line marker of ...

3 years, 7 months ago (2017-05-19 16:56:01 UTC) #3

messick

PTAL I think the test will fail on Windows but it works on Mac.

3 years, 7 months ago (2017-05-19 17:13:29 UTC) #4

Brian Wilkerson

I don't know whether it will pass or fail without actually running it on Windows. ...

3 years, 7 months ago (2017-05-19 17:25:55 UTC) #5

messick

I'll do that. package:test allows platform-specific tests but only at the file level.

3 years, 7 months ago (2017-05-19 17:28:00 UTC) #6

messick

3 years, 7 months ago (2017-05-19 17:28:52 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5455f2156507efd0bf518c658ecc9d849064798c (presubmit successful).