extensions/browser/api/runtime/runtime_api.cc - Issue 2892843002: Remove RuntimeAPIDelegate::GetPreviousVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/runtime/runtime_api.cc

Issue 2892843002: Remove RuntimeAPIDelegate::GetPreviousVersion. (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/runtime/runtime_api.cc

diff --git a/extensions/browser/api/runtime/runtime_api.cc b/extensions/browser/api/runtime/runtime_api.cc

index dbd9e915ece64464b8b380f6940b18b3c48fb252..47da999e70051b7d1eba78fa0a9d164b4a53c809 100644

--- a/extensions/browser/api/runtime/runtime_api.cc

+++ b/extensions/browser/api/runtime/runtime_api.cc

@@ -321,7 +321,7 @@ void RuntimeAPI::StorePendingOnInstallInfoToPref(const Extension* extension) {

std::unique_ptr<base::DictionaryValue> pending_on_install_info(

new base::DictionaryValue());

base::Version previous_version =

- delegate_->GetPreviousExtensionVersion(extension);

+ ExtensionRegistry::Get(browser_context_)->GetStoredVersion(extension);

pending_on_install_info->SetString(

kPrefPreviousVersion,

previous_version.IsValid() ? previous_version.GetString() : "");