Remove RuntimeAPIDelegate::GetPreviousVersion.

extensions/browser/extension_registry.cc

Index: extensions/browser/extension_registry.cc
diff --git a/extensions/browser/extension_registry.cc b/extensions/browser/extension_registry.cc
index 9c2bf16f53ec80f74192f883ae8753bbd51d8638..e92836a6049cdc3e7397cecbbeabd94c8492e191 100644
--- a/extensions/browser/extension_registry.cc
+++ b/extensions/browser/extension_registry.cc
@@ -5,6 +5,7 @@
 #include "extensions/browser/extension_registry.h"
 
 #include "base/strings/string_util.h"
+#include "base/version.h"

[Devlin, 2017/05/19 02:04:00]

(see header comment)

[lazyboy, 2017/05/19 18:24:55]

Removed.

 #include "extensions/browser/extension_registry_factory.h"
 #include "extensions/browser/extension_registry_observer.h"
 
@@ -40,6 +41,15 @@ std::unique_ptr<ExtensionSet> ExtensionRegistry::GenerateInstalledExtensionsSet(
   return installed_extensions;
 }
 
+base::Version ExtensionRegistry::GetVersion(const Extension* extension) const {
+  // TODO(lazyboy): Why not TERMINATED?
+  int include_mask = ExtensionRegistry::ENABLED | ExtensionRegistry::DISABLED |
+                     ExtensionRegistry::BLACKLISTED |
+                     ExtensionRegistry::BLOCKED;
+  const Extension* current = GetExtensionById(extension->id(), include_mask);
+  return current ? *current->version() : base::Version();

[Devlin, 2017/05/19 02:04:00]

maybe s/current/extension?  |current| to me still implies a temporal state,
which isn't necessarily the case with this method.

[lazyboy, 2017/05/19 18:24:55]

named registry_extension cause it collides with param otherwise.

+}
+
 void ExtensionRegistry::AddObserver(ExtensionRegistryObserver* observer) {
   observers_.AddObserver(observer);
 }