Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: extensions/browser/test_runtime_api_delegate.cc

Issue 2892843002: Remove RuntimeAPIDelegate::GetPreviousVersion. (Closed)
Patch Set: address missing comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/test_runtime_api_delegate.h" 5 #include "extensions/browser/test_runtime_api_delegate.h"
6 6
7 #include "extensions/common/api/runtime.h" 7 #include "extensions/common/api/runtime.h"
8 8
9 namespace extensions { 9 namespace extensions {
10 10
11 using api::runtime::PlatformInfo; 11 using api::runtime::PlatformInfo;
12 12
13 TestRuntimeAPIDelegate::TestRuntimeAPIDelegate() { 13 TestRuntimeAPIDelegate::TestRuntimeAPIDelegate() {
14 } 14 }
15 15
16 TestRuntimeAPIDelegate::~TestRuntimeAPIDelegate() { 16 TestRuntimeAPIDelegate::~TestRuntimeAPIDelegate() {
17 } 17 }
18 18
19 void TestRuntimeAPIDelegate::AddUpdateObserver(UpdateObserver* observer) { 19 void TestRuntimeAPIDelegate::AddUpdateObserver(UpdateObserver* observer) {
20 } 20 }
21 21
22 void TestRuntimeAPIDelegate::RemoveUpdateObserver(UpdateObserver* observer) { 22 void TestRuntimeAPIDelegate::RemoveUpdateObserver(UpdateObserver* observer) {
23 } 23 }
24 24
25 base::Version TestRuntimeAPIDelegate::GetPreviousExtensionVersion(
26 const Extension* extension) {
27 return base::Version();
28 }
29
30 void TestRuntimeAPIDelegate::ReloadExtension(const std::string& extension_id) { 25 void TestRuntimeAPIDelegate::ReloadExtension(const std::string& extension_id) {
31 } 26 }
32 27
33 bool TestRuntimeAPIDelegate::CheckForUpdates( 28 bool TestRuntimeAPIDelegate::CheckForUpdates(
34 const std::string& extension_id, 29 const std::string& extension_id,
35 const UpdateCheckCallback& callback) { 30 const UpdateCheckCallback& callback) {
36 return false; 31 return false;
37 } 32 }
38 33
39 void TestRuntimeAPIDelegate::OpenURL(const GURL& uninstall_url) { 34 void TestRuntimeAPIDelegate::OpenURL(const GURL& uninstall_url) {
40 } 35 }
41 36
42 bool TestRuntimeAPIDelegate::GetPlatformInfo(PlatformInfo* info) { 37 bool TestRuntimeAPIDelegate::GetPlatformInfo(PlatformInfo* info) {
43 // TODO(rockot): This probably isn't right. Maybe this delegate should just 38 // TODO(rockot): This probably isn't right. Maybe this delegate should just
44 // support manual PlatformInfo override for tests if necessary. 39 // support manual PlatformInfo override for tests if necessary.
45 info->os = api::runtime::PLATFORM_OS_CROS; 40 info->os = api::runtime::PLATFORM_OS_CROS;
46 return true; 41 return true;
47 } 42 }
48 43
49 bool TestRuntimeAPIDelegate::RestartDevice(std::string* error_message) { 44 bool TestRuntimeAPIDelegate::RestartDevice(std::string* error_message) {
50 return false; 45 return false;
51 } 46 }
52 47
53 } // namespace extensions 48 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/test_runtime_api_delegate.h ('k') | extensions/shell/browser/shell_runtime_api_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698