Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h

Issue 2892843002: Remove RuntimeAPIDelegate::GetPreviousVersion. (Closed)
Patch Set: address missing comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 // Sets a custom TickClock to use in tests. 44 // Sets a custom TickClock to use in tests.
45 static void set_tick_clock_for_tests(base::TickClock* clock); 45 static void set_tick_clock_for_tests(base::TickClock* clock);
46 46
47 private: 47 private:
48 friend class extensions::RuntimeAPI; 48 friend class extensions::RuntimeAPI;
49 49
50 // extensions::RuntimeAPIDelegate implementation. 50 // extensions::RuntimeAPIDelegate implementation.
51 void AddUpdateObserver(extensions::UpdateObserver* observer) override; 51 void AddUpdateObserver(extensions::UpdateObserver* observer) override;
52 void RemoveUpdateObserver(extensions::UpdateObserver* observer) override; 52 void RemoveUpdateObserver(extensions::UpdateObserver* observer) override;
53 base::Version GetPreviousExtensionVersion(
54 const extensions::Extension* extension) override;
55 void ReloadExtension(const std::string& extension_id) override; 53 void ReloadExtension(const std::string& extension_id) override;
56 bool CheckForUpdates(const std::string& extension_id, 54 bool CheckForUpdates(const std::string& extension_id,
57 const UpdateCheckCallback& callback) override; 55 const UpdateCheckCallback& callback) override;
58 void OpenURL(const GURL& uninstall_url) override; 56 void OpenURL(const GURL& uninstall_url) override;
59 bool GetPlatformInfo(extensions::api::runtime::PlatformInfo* info) override; 57 bool GetPlatformInfo(extensions::api::runtime::PlatformInfo* info) override;
60 bool RestartDevice(std::string* error_message) override; 58 bool RestartDevice(std::string* error_message) override;
61 bool OpenOptionsPage(const extensions::Extension* extension, 59 bool OpenOptionsPage(const extensions::Extension* extension,
62 content::BrowserContext* browser_context) override; 60 content::BrowserContext* browser_context) override;
63 61
64 // content::NotificationObserver implementation. 62 // content::NotificationObserver implementation.
(...skipping 28 matching lines...) Expand all
93 std::map<std::string, UpdateCheckInfo> update_check_info_; 91 std::map<std::string, UpdateCheckInfo> update_check_info_;
94 92
95 ScopedObserver<extensions::ExtensionRegistry, 93 ScopedObserver<extensions::ExtensionRegistry,
96 extensions::ExtensionRegistryObserver> 94 extensions::ExtensionRegistryObserver>
97 extension_registry_observer_; 95 extension_registry_observer_;
98 96
99 DISALLOW_COPY_AND_ASSIGN(ChromeRuntimeAPIDelegate); 97 DISALLOW_COPY_AND_ASSIGN(ChromeRuntimeAPIDelegate);
100 }; 98 };
101 99
102 #endif // CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_ 100 #endif // CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698