Remove RuntimeAPIDelegate::GetPreviousVersion.

extensions/browser/extension_registry.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_registry.h"
 
 #include "base/strings/string_util.h"
+#include "base/version.h"

[Devlin, 2017/05/19 02:04:00]

(see header comment)

[lazyboy, 2017/05/19 18:24:55]

Removed.

 #include "extensions/browser/extension_registry_factory.h"
 #include "extensions/browser/extension_registry_observer.h"
 
 namespace extensions {
 
 ExtensionRegistry::ExtensionRegistry(content::BrowserContext* browser_context)
     : browser_context_(browser_context) {}
 ExtensionRegistry::~ExtensionRegistry() {}
 
 // static
@@ skipping 15 matching lines @@
     installed_extensions->InsertAll(disabled_extensions_);
   if (include_mask & IncludeFlag::TERMINATED)
     installed_extensions->InsertAll(terminated_extensions_);
   if (include_mask & IncludeFlag::BLACKLISTED)
     installed_extensions->InsertAll(blacklisted_extensions_);
   if (include_mask & IncludeFlag::BLOCKED)
     installed_extensions->InsertAll(blocked_extensions_);
   return installed_extensions;
 }
 
+base::Version ExtensionRegistry::GetVersion(const Extension* extension) const {
+  // TODO(lazyboy): Why not TERMINATED?
+  int include_mask = ExtensionRegistry::ENABLED | ExtensionRegistry::DISABLED |
+                     ExtensionRegistry::BLACKLISTED |
+                     ExtensionRegistry::BLOCKED;
+  const Extension* current = GetExtensionById(extension->id(), include_mask);
+  return current ? *current->version() : base::Version();

[Devlin, 2017/05/19 02:04:00]

maybe s/current/extension?  |current| to me still implies a temporal state,
which isn't necessarily the case with this method.

[lazyboy, 2017/05/19 18:24:55]

named registry_extension cause it collides with param otherwise.

+}
+
 void ExtensionRegistry::AddObserver(ExtensionRegistryObserver* observer) {
   observers_.AddObserver(observer);
 }
 
 void ExtensionRegistry::RemoveObserver(ExtensionRegistryObserver* observer) {
   observers_.RemoveObserver(observer);
 }
 
 void ExtensionRegistry::TriggerOnLoaded(const Extension* extension) {
   CHECK(extension);
@@ skipping 149 matching lines @@
 }
 
 void ExtensionRegistry::Shutdown() {
   // Release references to all Extension objects in the sets.
   ClearAll();
   for (auto& observer : observers_)
     observer.OnShutdown(this);
 }
 
 }  // namespace extensions