Remove RuntimeAPIDelegate::GetPreviousVersion.

extensions/browser/extension_registry.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_registry.h"
 
 #include "base/strings/string_util.h"
+#include "base/version.h"
 #include "extensions/browser/extension_registry_factory.h"
 #include "extensions/browser/extension_registry_observer.h"
 
 namespace extensions {
 
 ExtensionRegistry::ExtensionRegistry(content::BrowserContext* browser_context)
     : browser_context_(browser_context) {}
 ExtensionRegistry::~ExtensionRegistry() {}
 
 // static
@@ skipping 15 matching lines @@
     installed_extensions->InsertAll(disabled_extensions_);
   if (include_mask & IncludeFlag::TERMINATED)
     installed_extensions->InsertAll(terminated_extensions_);
   if (include_mask & IncludeFlag::BLACKLISTED)
     installed_extensions->InsertAll(blacklisted_extensions_);
   if (include_mask & IncludeFlag::BLOCKED)
     installed_extensions->InsertAll(blocked_extensions_);
   return installed_extensions;
 }
 
+base::Version ExtensionRegistry::GetVersion(const Extension* extension) const {
+  int include_mask = ExtensionRegistry::ENABLED | ExtensionRegistry::DISABLED |
+                     ExtensionRegistry::BLACKLISTED |

[Devlin, 2017/05/19 01:07:09]

Why not terminated?

[lazyboy, 2017/05/19 01:38:48]

I don't know, this is copied from ExtensionService::GetExtensionById, with
include_disabled = true.
In order to avoid churn, I've added a todo and will add that separately. I don't
really want to introduce any functionality change in this CL.

+                     ExtensionRegistry::BLOCKED;
+  const Extension* old = GetExtensionById(extension->id(), include_mask);

[Devlin, 2017/05/19 01:07:09]

|old| is no longer accurate

[lazyboy, 2017/05/19 01:38:48]

Renamed.

+  return old ? *old->version() : base::Version();
+}
+
 void ExtensionRegistry::AddObserver(ExtensionRegistryObserver* observer) {
   observers_.AddObserver(observer);
 }
 
 void ExtensionRegistry::RemoveObserver(ExtensionRegistryObserver* observer) {
   observers_.RemoveObserver(observer);
 }
 
 void ExtensionRegistry::TriggerOnLoaded(const Extension* extension) {
   CHECK(extension);
@@ skipping 149 matching lines @@
 }
 
 void ExtensionRegistry::Shutdown() {
   // Release references to all Extension objects in the sets.
   ClearAll();
   for (auto& observer : observers_)
     observer.OnShutdown(this);
 }
 
 }  // namespace extensions