Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: src/objects-inl.h

Issue 289283018: Cleanup after inobject slack tracking improvement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing review comments + rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5213 matching lines...) Expand 10 before | Expand all | Expand 10 after
5224 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, bound, kBoundFunction) 5224 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, bound, kBoundFunction)
5225 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_anonymous, kIsAnonymous) 5225 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_anonymous, kIsAnonymous)
5226 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_function, kIsFunction) 5226 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_function, kIsFunction)
5227 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_optimize, 5227 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_optimize,
5228 kDontOptimize) 5228 kDontOptimize)
5229 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_inline, kDontInline) 5229 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_inline, kDontInline)
5230 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_cache, kDontCache) 5230 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_cache, kDontCache)
5231 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush) 5231 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush)
5232 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_generator, kIsGenerator) 5232 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_generator, kIsGenerator)
5233 5233
5234 void SharedFunctionInfo::BeforeVisitingPointers() {
5235 }
5236
5237
5238 ACCESSORS(CodeCache, default_cache, FixedArray, kDefaultCacheOffset) 5234 ACCESSORS(CodeCache, default_cache, FixedArray, kDefaultCacheOffset)
5239 ACCESSORS(CodeCache, normal_type_cache, Object, kNormalTypeCacheOffset) 5235 ACCESSORS(CodeCache, normal_type_cache, Object, kNormalTypeCacheOffset)
5240 5236
5241 ACCESSORS(PolymorphicCodeCache, cache, Object, kCacheOffset) 5237 ACCESSORS(PolymorphicCodeCache, cache, Object, kCacheOffset)
5242 5238
5243 bool Script::HasValidSource() { 5239 bool Script::HasValidSource() {
5244 Object* src = this->source(); 5240 Object* src = this->source();
5245 if (!src->IsString()) return true; 5241 if (!src->IsString()) return true;
5246 String* src_str = String::cast(src); 5242 String* src_str = String::cast(src);
5247 if (!StringShape(src_str).IsExternal()) return true; 5243 if (!StringShape(src_str).IsExternal()) return true;
(...skipping 1601 matching lines...) Expand 10 before | Expand all | Expand 10 after
6849 #undef READ_SHORT_FIELD 6845 #undef READ_SHORT_FIELD
6850 #undef WRITE_SHORT_FIELD 6846 #undef WRITE_SHORT_FIELD
6851 #undef READ_BYTE_FIELD 6847 #undef READ_BYTE_FIELD
6852 #undef WRITE_BYTE_FIELD 6848 #undef WRITE_BYTE_FIELD
6853 #undef NOBARRIER_READ_BYTE_FIELD 6849 #undef NOBARRIER_READ_BYTE_FIELD
6854 #undef NOBARRIER_WRITE_BYTE_FIELD 6850 #undef NOBARRIER_WRITE_BYTE_FIELD
6855 6851
6856 } } // namespace v8::internal 6852 } } // namespace v8::internal
6857 6853
6858 #endif // V8_OBJECTS_INL_H_ 6854 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698