Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: ui/events/BUILD.gn

Issue 289283015: Extract touchscreen device management into a generic manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/BUILD.gn
diff --git a/ui/events/BUILD.gn b/ui/events/BUILD.gn
index e2fe42b84dd97aa35d2d461bbc7a2914f52f7dd7..8b8700c12043a1d8c10437bc23a4a3bde8e230d1 100644
--- a/ui/events/BUILD.gn
+++ b/ui/events/BUILD.gn
@@ -16,6 +16,8 @@ static_library("dom4_keycode_converter") {
component("events_base") {
sources = [
+ "device_data_manager.cc",
+ "device_data_manager.h",
"event_constants.h",
"event_switches.cc",
"event_switches.h",
@@ -55,14 +57,16 @@ component("events_base") {
sources += [
"keycodes/keyboard_code_conversion_x.cc",
"keycodes/keyboard_code_conversion_x.h",
- "x/device_data_manager.cc",
- "x/device_data_manager.h",
+ "x/device_data_manager_x11.cc",
+ "x/device_data_manager_x11.h",
"x/device_list_cache_x.cc",
"x/device_list_cache_x.h",
"x/touch_factory_x11.cc",
"x/touch_factory_x11.h",
]
}
+
+ forward_dependent_configs_from = [ "//ui/gfx" ]
sadrul 2014/06/16 14:48:38 What does this do? Should this be a separate chang
dnicoara 2014/06/16 15:16:00 It's the GYP equivalent for export_dependent_setti
sadrul 2014/06/17 20:37:08 Can this be a separate CL? What change in this CL
dnicoara 2014/06/18 14:04:29 Removed it from this CL. The forward dependency w
sadrul 2014/06/18 16:18:14 The GN builder is tree closer, yes. You should add
dnicoara 2014/06/18 17:28:02 ui/events/platform/x11 didn't use to create the DD
}
component("events") {

Powered by Google App Engine
This is Rietveld 408576698