Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Side by Side Diff: chrome/browser/chromeos/device_uma.cc

Issue 289283015: Extract touchscreen device management into a generic manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/device_uma.h" 5 #include "chrome/browser/chromeos/device_uma.h"
6 6
7 #include <X11/extensions/XInput.h> 7 #include <X11/extensions/XInput.h>
8 #include <X11/extensions/XInput2.h> 8 #include <X11/extensions/XInput2.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/memory/singleton.h" 11 #include "base/memory/singleton.h"
12 #include "base/metrics/histogram.h" 12 #include "base/metrics/histogram.h"
13 #include "ui/events/event_constants.h" 13 #include "ui/events/event_constants.h"
14 #include "ui/events/event_utils.h" 14 #include "ui/events/event_utils.h"
15 #include "ui/events/platform/platform_event_source.h" 15 #include "ui/events/platform/platform_event_source.h"
16 #include "ui/events/x/device_data_manager.h" 16 #include "ui/events/x/device_data_manager_x11.h"
17 17
18 // Enum type for CrOS gesture lib UMA 18 // Enum type for CrOS gesture lib UMA
19 enum UMACrosGestureMetricsType{ 19 enum UMACrosGestureMetricsType{
20 // To give an estimated number of all interested events. 20 // To give an estimated number of all interested events.
21 UMA_CROS_GESTURE_METRICS_ALL_EVENTS, 21 UMA_CROS_GESTURE_METRICS_ALL_EVENTS,
22 UMA_CROS_GESTURE_METRICS_NOISY_GROUND, 22 UMA_CROS_GESTURE_METRICS_NOISY_GROUND,
23 // NOTE: Add states only immediately above this line. Make sure to 23 // NOTE: Add states only immediately above this line. Make sure to
24 // update the enum list in tools/metrics/histograms/histograms.xml 24 // update the enum list in tools/metrics/histograms/histograms.xml
25 // accordingly. 25 // accordingly.
26 UMA_CROS_GESTURE_METRICS_COUNT 26 UMA_CROS_GESTURE_METRICS_COUNT
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 XIDeviceEvent* xiev = 59 XIDeviceEvent* xiev =
60 static_cast<XIDeviceEvent*>(native_event->xcookie.data); 60 static_cast<XIDeviceEvent*>(native_event->xcookie.data);
61 // We take only the slave event since there is no need to count twice. 61 // We take only the slave event since there is no need to count twice.
62 if (xiev->deviceid != xiev->sourceid) 62 if (xiev->deviceid != xiev->sourceid)
63 return; 63 return;
64 UMA_HISTOGRAM_ENUMERATION("Touchpad.Metrics", 64 UMA_HISTOGRAM_ENUMERATION("Touchpad.Metrics",
65 UMA_CROS_GESTURE_METRICS_ALL_EVENTS, 65 UMA_CROS_GESTURE_METRICS_ALL_EVENTS,
66 UMA_CROS_GESTURE_METRICS_COUNT); 66 UMA_CROS_GESTURE_METRICS_COUNT);
67 67
68 // Check for the CrOS touchpad metrics gesture 68 // Check for the CrOS touchpad metrics gesture
69 ui::DeviceDataManager *manager = ui::DeviceDataManager::GetInstance(); 69 ui::DeviceDataManagerX11 *manager = ui::DeviceDataManagerX11::GetInstance();
70 if (manager->IsCMTMetricsEvent(native_event)) { 70 if (manager->IsCMTMetricsEvent(native_event)) {
71 ui::GestureMetricsType type; 71 ui::GestureMetricsType type;
72 float data1, data2; 72 float data1, data2;
73 manager->GetMetricsData(native_event, &type, &data1, &data2); 73 manager->GetMetricsData(native_event, &type, &data1, &data2);
74 74
75 // We currently track only the noisy ground issue. Please see 75 // We currently track only the noisy ground issue. Please see
76 // http://crbug.com/237683. 76 // http://crbug.com/237683.
77 if (type == ui::kGestureMetricsTypeNoisyGround) { 77 if (type == ui::kGestureMetricsTypeNoisyGround) {
78 UMA_HISTOGRAM_ENUMERATION("Touchpad.Metrics", 78 UMA_HISTOGRAM_ENUMERATION("Touchpad.Metrics",
79 UMA_CROS_GESTURE_METRICS_NOISY_GROUND, 79 UMA_CROS_GESTURE_METRICS_NOISY_GROUND,
80 UMA_CROS_GESTURE_METRICS_COUNT); 80 UMA_CROS_GESTURE_METRICS_COUNT);
81 } 81 }
82 } 82 }
83 } 83 }
84 84
85 void DeviceUMA::CheckIncomingEvent(XEvent* event) { 85 void DeviceUMA::CheckIncomingEvent(XEvent* event) {
86 switch (event->type) { 86 switch (event->type) {
87 case GenericEvent: { 87 case GenericEvent: {
88 if (ui::DeviceDataManager::GetInstance()->IsXIDeviceEvent(event) && 88 if (ui::DeviceDataManagerX11::GetInstance()->IsXIDeviceEvent(event) &&
89 ui::IsTouchpadEvent(event)) 89 ui::IsTouchpadEvent(event))
90 CheckTouchpadEvent(event); 90 CheckTouchpadEvent(event);
91 break; 91 break;
92 } 92 }
93 default: 93 default:
94 break; 94 break;
95 } 95 }
96 return; 96 return;
97 } 97 }
98 98
99 } // namespace chromeos 99 } // namespace chromeos
OLDNEW
« no previous file with comments | « ash/wm/maximize_mode/internal_input_device_list_x11.cc ('k') | chrome/browser/metrics/chromeos_metrics_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698