Extract touchscreen device management into a generic manager

chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chromeos_metrics_provider.h"
 
 #include <string>
 
+#include "base/at_exit.h"
 #include "base/basictypes.h"
 #include "chrome/browser/chromeos/login/users/fake_user_manager.h"
 #include "chrome/browser/chromeos/login/users/user_manager.h"
 #include "chrome/browser/metrics/chromeos_metrics_provider.h"
 #include "chromeos/dbus/fake_bluetooth_adapter_client.h"
 #include "chromeos/dbus/fake_bluetooth_agent_manager_client.h"
 #include "chromeos/dbus/fake_bluetooth_device_client.h"
 #include "chromeos/dbus/fake_bluetooth_gatt_characteristic_client.h"
 #include "chromeos/dbus/fake_bluetooth_gatt_descriptor_client.h"
 #include "chromeos/dbus/fake_bluetooth_gatt_service_client.h"
 #include "chromeos/dbus/fake_bluetooth_input_client.h"
 #include "chromeos/dbus/fake_dbus_thread_manager.h"
 #include "chromeos/login/login_state.h"
 #include "components/metrics/proto/system_profile.pb.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+#if defined(USE_X11)
+#include "ui/events/x/device_data_manager_x11.h"
+#endif
+
 using chromeos::DBusThreadManager;
 using chromeos::BluetoothAdapterClient;
 using chromeos::BluetoothAgentManagerClient;
 using chromeos::BluetoothDeviceClient;
 using chromeos::BluetoothGattCharacteristicClient;
 using chromeos::BluetoothGattDescriptorClient;
 using chromeos::BluetoothGattServiceClient;
 using chromeos::BluetoothInputClient;
 using chromeos::FakeBluetoothAdapterClient;
 using chromeos::FakeBluetoothAgentManagerClient;
 using chromeos::FakeBluetoothDeviceClient;
 using chromeos::FakeBluetoothGattCharacteristicClient;
 using chromeos::FakeBluetoothGattDescriptorClient;
 using chromeos::FakeBluetoothGattServiceClient;
 using chromeos::FakeBluetoothInputClient;
 using chromeos::FakeDBusThreadManager;
 
 class ChromeOSMetricsProviderTest : public testing::Test {
  public:
   ChromeOSMetricsProviderTest() {}
 
  protected:
   virtual void SetUp() OVERRIDE {
+#if defined(USE_X11)
+    // AtExitManager keeps track of its lifetime.
+    new ui::DeviceDataManagerX11();
+#endif
+
     // Set up the fake Bluetooth environment,
     scoped_ptr<FakeDBusThreadManager> fake_dbus_thread_manager(
         new FakeDBusThreadManager);
     fake_dbus_thread_manager->SetBluetoothAdapterClient(
         scoped_ptr<BluetoothAdapterClient>(new FakeBluetoothAdapterClient));
     fake_dbus_thread_manager->SetBluetoothDeviceClient(
         scoped_ptr<BluetoothDeviceClient>(new FakeBluetoothDeviceClient));
     fake_dbus_thread_manager->SetBluetoothGattCharacteristicClient(
         scoped_ptr<BluetoothGattCharacteristicClient>(
             new FakeBluetoothGattCharacteristicClient));
@@ skipping 26 matching lines @@
     chromeos::LoginState::Shutdown();
 
     DBusThreadManager::Shutdown();
   }
 
  protected:
   FakeBluetoothAdapterClient* fake_bluetooth_adapter_client_;
   FakeBluetoothDeviceClient* fake_bluetooth_device_client_;
 
  private:
+  base::ShadowingAtExitManager at_exit_;

[sadrul, 2014/06/16 14:48:37]

Requiring all tests that use the DDMX11 to have a ShadowingAtExitManager seems
like an extra burden. Can we remove this?

[dnicoara, 2014/06/16 15:13:56]

Only if DeviceDataManager allows calling CreateInstance() (soon to be
introduced) multiple times, rather than performing the CHECK in
DeviceDataManager's constructor. I was under the impression you didn't like this
approach.

[sadrul, 2014/06/17 20:37:08]

We should avoid calling CreateInstance() from too many places. But calling them
multiple times doesn't sound bad. (of course, given that only the first call
actually creates a new instance, and subsequent calls are no-ops)

[dnicoara, 2014/06/18 14:04:29]

Done.

   content::TestBrowserThreadBundle thread_bundle_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeOSMetricsProviderTest);
 };
 
 TEST_F(ChromeOSMetricsProviderTest, MultiProfileUserCount) {
   std::string user1("user1@example.com");
   std::string user2("user2@example.com");
   std::string user3("user3@example.com");
 
@@ skipping 118 matching lines @@
   // Second device should match the Confirm Passkey object, this has
   // no Device ID information.
   PairedDevice device2 = system_profile.hardware().bluetooth().paired_device(1);
 
   EXPECT_EQ(FakeBluetoothDeviceClient::kConfirmPasskeyClass,
             device2.bluetooth_class());
   EXPECT_EQ(PairedDevice::DEVICE_PHONE, device2.type());
   EXPECT_EQ(0x207D74U, device2.vendor_prefix());
   EXPECT_EQ(PairedDevice::VENDOR_ID_UNKNOWN, device2.vendor_id_source());
 }