Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 289283014: Cast: Fake software video encoder to respect target bitrate (Closed)

Created:
6 years, 7 months ago by Alpha Left Google
Modified:
6 years, 7 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Visibility:
Public.

Description

Cast: Fake software video encoder to respect target bitrate This change is to enable simulation using fake software encoder. It now respects the target bitrate and fill the fake frame with space characers. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272257

Patch Set 1 #

Patch Set 2 : smaller number of iterations #

Total comments: 1

Patch Set 3 : lowered bitrate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M media/cast/test/end2end_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M media/cast/video_sender/fake_software_video_encoder.h View 3 chunks +4 lines, -1 line 0 comments Download
M media/cast/video_sender/fake_software_video_encoder.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M media/cast/video_sender/video_encoder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Alpha Left Google
6 years, 7 months ago (2014-05-21 23:02:40 UTC) #1
hubbe
https://codereview.chromium.org/289283014/diff/20001/media/cast/test/end2end_unittest.cc File media/cast/test/end2end_unittest.cc (right): https://codereview.chromium.org/289283014/diff/20001/media/cast/test/end2end_unittest.cc#newcode1311 media/cast/test/end2end_unittest.cc:1311: for (; frames_counter < 1000; ++frames_counter) { Can we ...
6 years, 7 months ago (2014-05-21 23:07:00 UTC) #2
Alpha Left Google
Done. Reduced bitrate to 1/100 of the previous values and give it 10k frames.
6 years, 7 months ago (2014-05-21 23:47:43 UTC) #3
Alpha Left Google
Just did.
6 years, 7 months ago (2014-05-22 00:24:57 UTC) #4
hubbe
lgtm
6 years, 7 months ago (2014-05-22 00:25:55 UTC) #5
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 7 months ago (2014-05-22 01:14:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/289283014/40001
6 years, 7 months ago (2014-05-22 01:17:26 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 10:06:50 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 10:09:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9709)
6 years, 7 months ago (2014-05-22 10:09:22 UTC) #10
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 7 months ago (2014-05-22 18:52:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/289283014/40001
6 years, 7 months ago (2014-05-22 18:53:31 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 18:59:13 UTC) #13
Message was sent while issue was closed.
Change committed as 272257

Powered by Google App Engine
This is Rietveld 408576698