Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 289283013: Revert of Unload all apps / extensions when deleting a profile. (Closed)

Created:
6 years, 7 months ago by scheib
Modified:
6 years, 7 months ago
Reviewers:
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Revert of Unload all apps / extensions when deleting a profile. (https://codereview.chromium.org/266343002/) Reason for revert: Caused crash in official builds when deleting profiles while the chrome:chrome-signin tab is open BUG=374683 TBR=kalman, sky Original issue's description: > Unload all apps / extensions immediately when deleting a profile. > > Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile. > > Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed. > > [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353 > [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355 > [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362 > > BUG=368684 > TEST=Manual testing as described on http://crbug.com/368684#c1 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270890 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -87 lines) Patch
M chrome/browser/background/background_contents_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chrome_notification_types.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 9 chunks +5 lines, -35 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/browser/process_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M extensions/common/extension.h View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheib
Created Revert of Unload all apps / extensions when deleting a profile.
6 years, 7 months ago (2014-05-21 16:59:25 UTC) #1
scheib
6 years, 7 months ago (2014-05-21 18:25:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698