chrome/browser/extensions/bookmark_app_helper.cc - Issue 289283004: Add ability to constrain dominant color selection to a HSL range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bookmark_app_helper.cc

Issue 289283004: Add ability to constrain dominant color selection to a HSL range. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: make bounds inclusive, add saturation test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/bookmark_app_helper.cc

diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc

index a44c002a1d22e2dee5d1f8573234960223eded56..b15c91d3cde84c1ca2fabe4424177147d57c9665 100644

--- a/chrome/browser/extensions/bookmark_app_helper.cc

+++ b/chrome/browser/extensions/bookmark_app_helper.cc

@@ -110,13 +110,9 @@ void BookmarkAppHelper::GenerateContainerIcon(std::map<int, SkBitmap>* bitmaps,

// Draw a rounded rect of the |base_icon|'s dominant color.

SkPaint color_strip_paint;

- color_utils::GridSampler sampler;

color_strip_paint.setFlags(SkPaint::kAntiAlias_Flag);

- color_strip_paint.setColor(color_utils::CalculateKMeanColorOfPNG(

- gfx::Image::CreateFrom1xBitmap(base_icon).As1xPNGBytes(),

- 100,

- 665,

- &sampler));

+ color_strip_paint.setColor(

+ color_utils::CalculateKMeanColorOfBitmap(base_icon));

color_strip_canvas->drawRoundRect(SkRect::MakeWH(output_size, output_size),

kBorderRadius,