Issue 2892793004: Remove unused variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2892793004: Remove unused variable (Closed)

Created:
3 years, 7 months ago by erikcorry

Modified:
3 years, 7 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove unused variable TBR=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5182eeab26e34054e220613bfa2642ac5d2cf40b

Patch Set 1 #

Patch Set 2 : x64 #

Total comments: 1

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View		2 chunks	+1 line, -2 lines	1 comment	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

erikcorry

Committed patchset #2 (id:20001) manually as 5182eeab26e34054e220613bfa2642ac5d2cf40b (presubmit successful).

3 years, 7 months ago (2017-05-19 07:08:36 UTC) #3

kustermann

3 years, 7 months ago (2017-05-19 07:59:42 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2892793004/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_mips.cc (left):

https://codereview.chromium.org/2892793004/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_mips.cc:1568: __ LoadImmediate(TMP, cid_end -
cid_end);
end - end :)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages