Issue 289273003: Use forward declaration instead of include for NPObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289273003: Use forward declaration instead of include for NPObject (Closed)

Created:
6 years, 7 months ago by Jiang Jiang

Modified:
6 years, 7 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use forward declaration instead of include for NPObject All we use is just a NPObject* here, there is no need to include the entire third_party/npapi/bindings/npruntime.h file, plus that file includes third_party/npapi/bindings/npapi.h which further includes system gl.h in OS X, which contains a GLES2TexImage2D definition that conflicts with the definition in gpu/GLES2/gl2chromium_autogen.h. Similar issues were fixed in CL https://codereview.chromium.org/11794019/ We will hit this issue when trying to include V8NPObject.h along with ChromeClientImpl.h. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174283