Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 289273003: Use forward declaration instead of include for NPObject (Closed)

Created:
6 years, 7 months ago by Jiang Jiang
Modified:
6 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use forward declaration instead of include for NPObject All we use is just a NPObject* here, there is no need to include the entire third_party/npapi/bindings/npruntime.h file, plus that file includes third_party/npapi/bindings/npapi.h which further includes system gl.h in OS X, which contains a GLES2TexImage2D definition that conflicts with the definition in gpu/GLES2/gl2chromium_autogen.h. Similar issues were fixed in CL https://codereview.chromium.org/11794019/ We will hit this issue when trying to include V8NPObject.h along with ChromeClientImpl.h. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/bindings/v8/V8NPObject.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jiang Jiang
6 years, 7 months ago (2014-05-19 09:41:01 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-19 09:49:26 UTC) #2
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 7 months ago (2014-05-19 10:22:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/289273003/1
6 years, 7 months ago (2014-05-19 10:22:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 12:54:13 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 14:08:28 UTC) #6
Message was sent while issue was closed.
Change committed as 174283

Powered by Google App Engine
This is Rietveld 408576698