Source/core/page/DragData.cpp - Issue 289273002: Oilpan: make DocumentFragment a heap allocated object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DragData.cpp

Issue 289273002: Oilpan: make DocumentFragment a heap allocated object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + add WillBeGarbageCollected FIXME. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DragData.cpp

diff --git a/Source/core/page/DragData.cpp b/Source/core/page/DragData.cpp

index 84157d40da512dfda7dee136f4f38684ff4b92d5..fb7eb83fe108e9d1f4a6957fd0937b82a78bdac2 100644

--- a/Source/core/page/DragData.cpp

+++ b/Source/core/page/DragData.cpp

@@ -131,7 +131,7 @@ bool DragData::containsCompatibleContent() const

|| containsFiles();

}

-PassRefPtr<DocumentFragment> DragData::asFragment(LocalFrame* frame, PassRefPtrWillBeRawPtr<Range>, bool, bool&) const

+PassRefPtrWillBeRawPtr<DocumentFragment> DragData::asFragment(LocalFrame* frame, PassRefPtrWillBeRawPtr<Range>, bool, bool&) const

{

* Order is richest format first. On OSX this is:

@@ -153,7 +153,7 @@ PassRefPtr<DocumentFragment> DragData::asFragment(LocalFrame* frame, PassRefPtrW

KURL baseURL;

m_platformDragData->htmlAndBaseURL(html, baseURL);

ASSERT(frame->document());

- if (RefPtr<DocumentFragment> fragment = createFragmentFromMarkup(*frame->document(), html, baseURL, DisallowScriptingAndPluginContent))

+ if (RefPtrWillBeRawPtr<DocumentFragment> fragment = createFragmentFromMarkup(*frame->document(), html, baseURL, DisallowScriptingAndPluginContent))

return fragment.release();

}

« no previous file with comments | « Source/core/page/DragData.h ('k') | Source/core/xml/XSLTProcessor.h » ('j') | no next file with comments »