Source/core/inspector/InspectorDOMAgent.cpp - Issue 289273002: Oilpan: make DocumentFragment a heap allocated object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 289273002: Oilpan: make DocumentFragment a heap allocated object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + add WillBeGarbageCollected FIXME. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp

index 00ea53088d704d089c8cdd91d8e7695926d7ccf0..10a91824779485dac41d5e712a3320748cbf2e45 100644

--- a/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/Source/core/inspector/InspectorDOMAgent.cpp

@@ -670,7 +670,7 @@ void InspectorDOMAgent::setAttributesAsText(ErrorString* errorString, int elemen

return;

String markup = "<span " + text + "></span>";

- RefPtr<DocumentFragment> fragment = element->document().createDocumentFragment();

+ RefPtrWillBeRawPtr<DocumentFragment> fragment = element->document().createDocumentFragment();

bool shouldIgnoreCase = element->document().isHTMLDocument() && element->isHTMLElement();

// Not all elements can represent the context (i.e. IFRAME), hence using document.body.

« no previous file with comments | « Source/core/inspector/DOMPatchSupport.cpp ('k') | Source/core/page/DragController.cpp » ('j') | no next file with comments »