Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: Source/core/html/HTMLElement.cpp

Issue 289273002: Oilpan: make DocumentFragment a heap allocated object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + add WillBeGarbageCollected FIXME. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLElement.cpp
diff --git a/Source/core/html/HTMLElement.cpp b/Source/core/html/HTMLElement.cpp
index c7e6eec81e8fdc6f9b10e2aff060bc58ae8fedb9..dc655abd6c04c41d4cc7e945132a7b4a16e66663 100644
--- a/Source/core/html/HTMLElement.cpp
+++ b/Source/core/html/HTMLElement.cpp
@@ -318,9 +318,9 @@ void HTMLElement::parseAttribute(const QualifiedName& name, const AtomicString&
}
}
-PassRefPtr<DocumentFragment> HTMLElement::textToFragment(const String& text, ExceptionState& exceptionState)
+PassRefPtrWillBeRawPtr<DocumentFragment> HTMLElement::textToFragment(const String& text, ExceptionState& exceptionState)
{
- RefPtr<DocumentFragment> fragment = DocumentFragment::create(document());
+ RefPtrWillBeRawPtr<DocumentFragment> fragment = DocumentFragment::create(document());
unsigned i, length = text.length();
UChar c = 0;
for (unsigned start = 0; start < length; ) {
@@ -393,7 +393,7 @@ void HTMLElement::setInnerText(const String& text, ExceptionState& exceptionStat
}
// Add text nodes and <br> elements.
- RefPtr<DocumentFragment> fragment = textToFragment(text, exceptionState);
+ RefPtrWillBeRawPtr<DocumentFragment> fragment = textToFragment(text, exceptionState);
if (!exceptionState.hadException())
replaceChildrenWithFragment(this, fragment.release(), exceptionState);
}
« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698