Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: Source/core/editing/EditorCommand.cpp

Issue 289273002: Oilpan: make DocumentFragment a heap allocated object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + add WillBeGarbageCollected FIXME. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/MoveSelectionCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/EditorCommand.cpp
diff --git a/Source/core/editing/EditorCommand.cpp b/Source/core/editing/EditorCommand.cpp
index 0ca0c7fde0c56c860c044e86191915e6a8aa94b0..b0ffaeb939535b96eba45fcf6c5dbf3d91237fb3 100644
--- a/Source/core/editing/EditorCommand.cpp
+++ b/Source/core/editing/EditorCommand.cpp
@@ -191,7 +191,7 @@ static bool executeApplyParagraphStyle(LocalFrame& frame, EditorCommandSource so
return false;
}
-static bool executeInsertFragment(LocalFrame& frame, PassRefPtr<DocumentFragment> fragment)
+static bool executeInsertFragment(LocalFrame& frame, PassRefPtrWillBeRawPtr<DocumentFragment> fragment)
{
ASSERT(frame.document());
ReplaceSelectionCommand::create(*frame.document(), fragment, ReplaceSelectionCommand::PreventNesting, EditActionUnspecified)->apply();
@@ -201,7 +201,7 @@ static bool executeInsertFragment(LocalFrame& frame, PassRefPtr<DocumentFragment
static bool executeInsertNode(LocalFrame& frame, PassRefPtr<Node> content)
{
ASSERT(frame.document());
- RefPtr<DocumentFragment> fragment = DocumentFragment::create(*frame.document());
+ RefPtrWillBeRawPtr<DocumentFragment> fragment = DocumentFragment::create(*frame.document());
TrackExceptionState exceptionState;
fragment->appendChild(content, exceptionState);
if (exceptionState.hadException())
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/MoveSelectionCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698