Source/core/editing/CompositeEditCommand.cpp - Issue 289273002: Oilpan: make DocumentFragment a heap allocated object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.cpp

Issue 289273002: Oilpan: make DocumentFragment a heap allocated object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + add WillBeGarbageCollected FIXME. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/CompositeEditCommand.cpp

diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp

index afbe555316d63e70279ed6c4c4c57d57d8bc41a4..1112179f20757e411041dd682876d3973e6f4752 100644

--- a/Source/core/editing/CompositeEditCommand.cpp

+++ b/Source/core/editing/CompositeEditCommand.cpp

@@ -1189,7 +1189,7 @@ void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagrap

// FIXME: This is an inefficient way to preserve style on nodes in the paragraph to move. It

// shouldn't matter though, since moved paragraphs will usually be quite small.

- RefPtr<DocumentFragment> fragment = startOfParagraphToMove != endOfParagraphToMove ?

+ RefPtrWillBeRawPtr<DocumentFragment> fragment = startOfParagraphToMove != endOfParagraphToMove ?

createFragmentFromMarkup(document(), createMarkup(range.get(), 0, DoNotAnnotateForInterchange, true, DoNotResolveURLs, constrainingAncestor), "") : nullptr;

// A non-empty paragraph's style is moved when we copy and move it. We don't move

« no previous file with comments | « Source/core/dom/shadow/ShadowRoot.cpp ('k') | Source/core/editing/Editor.h » ('j') | no next file with comments »