Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: chrome/browser/resources/pdf/viewport.js

Issue 2892623002: Type check PDF plugin JS code, down to 53 errors. (Closed)
Patch Set: Revert compiled_resources2.gyp for now. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/pdf/toolbar_manager.js ('k') | chrome/browser/resources/pdf/viewport_scroller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/viewport.js
diff --git a/chrome/browser/resources/pdf/viewport.js b/chrome/browser/resources/pdf/viewport.js
index 607f70ed90745e88c8186d10fc24b715a302a7cb..6d027f1c8ee6db68adfacb035bfab0829f83fe53 100644
--- a/chrome/browser/resources/pdf/viewport.js
+++ b/chrome/browser/resources/pdf/viewport.js
@@ -446,8 +446,8 @@ Viewport.prototype = {
/**
* @private
- * @param {integer} y the y-coordinate to get the page at.
- * @return {integer} the index of a page overlapping the given y-coordinate.
+ * @param {number} y the y-coordinate to get the page at.
+ * @return {number} the index of a page overlapping the given y-coordinate.
*/
getPageAtY_: function(y) {
var min = 0;
@@ -477,7 +477,7 @@ Viewport.prototype = {
/**
* Returns the page with the greatest proportion of its height in the current
* viewport.
- * @return {int} the index of the most visible page.
+ * @return {number} the index of the most visible page.
*/
getMostVisiblePage: function() {
var firstVisiblePage = this.getPageAtY_(this.position.y / this.zoom);
« no previous file with comments | « chrome/browser/resources/pdf/toolbar_manager.js ('k') | chrome/browser/resources/pdf/viewport_scroller.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698