Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2892613002: IOThread: Use URLRequestContextBuilder::NetworkSessionParams. (Closed)

Created:
3 years, 7 months ago by mmenke
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

IOThread: Use URLRequestContextBuilder::HttpNetworkSessionParams. This gets us one step closer to using URLRequestContextBuilder for IOThread and ProfileIOData. Also expand URLRequestContextBuilder::HttpNetworkSessionParams to include everything that IOThread needs to configure its HttpNetworkSession. BUG=715695

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Merge #

Patch Set 4 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -33 lines) Patch
M chrome/browser/io_thread.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M components/network_session_configurator/network_session_configurator.h View 2 chunks +6 lines, -5 lines 0 comments Download
M components/network_session_configurator/network_session_configurator.cc View 4 chunks +19 lines, -15 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_versions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 2 3 5 chunks +15 lines, -1 line 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 3 4 chunks +23 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2872133005 Patch 260001

Messages

Total messages: 9 (9 generated)
mmenke
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 17:37:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892613002/1
3 years, 7 months ago (2017-05-17 17:39:18 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 17:44:27 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/270308) linux_android_rel_ng on ...
3 years, 7 months ago (2017-05-17 17:44:27 UTC) #4
mmenke
Description was changed from ========== IOThread: Use URLRequestContextBuilder::NetworkSessionParams. This gets us one step closer to ...
3 years, 7 months ago (2017-05-17 18:28:11 UTC) #5
mmenke
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 18:28:28 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892613002/20001
3 years, 7 months ago (2017-05-17 18:29:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 18:42:50 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 18:42:51 UTC) #9 
Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698