Issue 2892593005: Handle FutureOr type when inferring async closures.

Issue 2892593005: Handle FutureOr type when inferring async closures. (Closed)

Created:
3 years, 7 months ago by Paul Berry

Modified:
3 years, 7 months ago

Reviewers:
asgerf, Kevin Millikin (Chromium), scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -2 lines)			Patch
M	pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	pkg/front_end/test/fasta/strong.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/front_end/testcases/inference/async_closure_return_type_future_or.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/async_closure_return_type_future_or.dart.strong.expect	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	pkg/kernel/lib/core_types.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/kernel/lib/testing/mock_sdk_program.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Paul Berry

Konstantin to review front_end changes. Kevin or Asger to review kernel changes. Konstantin: these changes ...

3 years, 7 months ago (2017-05-17 22:01:43 UTC) #2

scheglov

LGTM Land your change, it should be easy for me to merge it manually.

3 years, 7 months ago (2017-05-17 22:05:08 UTC) #3

Paul Berry

3 years, 7 months ago (2017-05-21 03:17:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bf15116d0f8cc90455552a4f5763695f5d929fd0 (presubmit successful).