Avoid base::Time::FromJavaTime() when not dealing with Java.

chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ntp_snippets/download_suggestions_provider.h"
 
 #include <memory>
+#include <utility>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/observer_list.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/test/simple_test_clock.h"
 #include "base/time/default_clock.h"
 #include "components/ntp_snippets/category.h"
 #include "components/ntp_snippets/mock_content_suggestions_provider_observer.h"
 #include "components/ntp_snippets/offline_pages/offline_pages_test_utils.h"
@@ skipping 64 matching lines @@
   }
   return os;
 }
 
 }  // namespace ntp_snippets
 
 namespace {
 
 const int kDefaultMaxDownloadAgeHours = 6 * 7 * 24;
 
-// Tue, 31 Jan 2017 13:00:00 UTC
-const base::Time now = base::Time::FromJavaTime(1485867600000);
+base::Time CalculateDummyNowTime() {
+  base::Time now;
+  CHECK(base::Time::FromUTCString("2017-01-31 13:00:00", &now));
+  return now;
+}
+
+const base::Time now = CalculateDummyNowTime();

[miu, 2017/05/22 21:45:31]

Global static initializer here. So, this goes against the style guide, unless we
are willing to make an exception for unit test code?

[Lei Zhang, 2017/05/22 22:03:57]

Yes, which is what I was avoiding in patch set 1. However, we have tons of
static initializers in tests, and we don't have any enforcement for unit tests,
so I was meh about it.

+
+base::Time GetDummyNotOutdatedTime() {
+  return now - base::TimeDelta::FromHours(kDefaultMaxDownloadAgeHours) +
+         base::TimeDelta::FromSeconds(1);
+}
+
+base::Time GetDummyOutdatedTime() {
+  return now - base::TimeDelta::FromHours(kDefaultMaxDownloadAgeHours) -
+         base::TimeDelta::FromSeconds(1);
+}
 
 // TODO(vitaliii): Move this and outputting functions above to common file and
 // replace remaining |Property(&ContentSuggestion::url, GURL("some_url"))|.
 // See crbug.com/655513.
 MATCHER_P(HasUrl, url, "") {
   *result_listener << "expected URL: " << url
                    << "has URL: " << arg.url().spec();
   return arg.url().spec() == url;
 }
 
@@ skipping 924 matching lines @@
 
   *(downloads_manager()->mutable_items()) = CreateDummyAssetDownloads({1});
   // Once the manager has been loaded, the ids should be pruned.
   EXPECT_THAT(GetDismissedSuggestions(), IsEmpty());
 }
 
 TEST_F(DownloadSuggestionsProviderTest, ShouldNotShowOutdatedDownloads) {
   IgnoreOnCategoryStatusChangedToAvailable();
   IgnoreOnSuggestionInvalidated();
 
-  const base::Time not_outdated =
-      now - base::TimeDelta::FromHours(kDefaultMaxDownloadAgeHours) +
-      base::TimeDelta::FromSeconds(1);
-  const base::Time outdated =
-      now - base::TimeDelta::FromHours(kDefaultMaxDownloadAgeHours) -
-      base::TimeDelta::FromSeconds(1);
+  const base::Time not_outdated = GetDummyNotOutdatedTime();
+  const base::Time outdated = GetDummyOutdatedTime();
 
   *(offline_pages_model()->mutable_items()) = CreateDummyOfflinePages({0, 1});
 
   offline_pages_model()->mutable_items()->at(0).url =
       GURL("http://dummy.com/0");
   offline_pages_model()->mutable_items()->at(0).creation_time = not_outdated;
   offline_pages_model()->mutable_items()->at(0).last_access_time = not_outdated;
 
   offline_pages_model()->mutable_items()->at(1).url =
       GURL("http://dummy.com/1");
@@ skipping 19 matching lines @@
   test_clock->SetNow(now);
   CreateLoadedProvider(/*show_assets=*/true, /*show_offline_pages=*/true,
                        std::move(test_clock));
 }
 
 TEST_F(DownloadSuggestionsProviderTest,
        ShouldShowRecentlyVisitedOfflinePageDownloads) {
   IgnoreOnCategoryStatusChangedToAvailable();
   IgnoreOnSuggestionInvalidated();
 
-  const base::Time not_outdated =
-      now - base::TimeDelta::FromHours(kDefaultMaxDownloadAgeHours) +
-      base::TimeDelta::FromSeconds(1);
-  const base::Time outdated =
-      now - base::TimeDelta::FromHours(kDefaultMaxDownloadAgeHours) -
-      base::TimeDelta::FromSeconds(1);
+  const base::Time not_outdated = GetDummyNotOutdatedTime();
+  const base::Time outdated = GetDummyOutdatedTime();
 
   std::vector<OfflinePageItem> offline_pages = CreateDummyOfflinePages({0, 1});
 
   offline_pages[0].url = GURL("http://dummy.com/0");
   offline_pages[0].creation_time = outdated;
   offline_pages[0].last_access_time = not_outdated;
 
   offline_pages[1].url = GURL("http://dummy.com/1");
   offline_pages[1].creation_time = outdated;
   offline_pages[1].last_access_time = offline_pages[1].creation_time;
@@ skipping 10 matching lines @@
   test_clock->SetNow(now);
   CreateProvider(/*show_assets=*/false, /*show_offline_pages=*/true,
                  std::move(test_clock));
 }
 
 TEST_F(DownloadSuggestionsProviderTest,
        ShouldShowRecentlyVisitedAssetDownloads) {
   IgnoreOnCategoryStatusChangedToAvailable();
   IgnoreOnSuggestionInvalidated();
 
-  const base::Time not_outdated =
-      now - base::TimeDelta::FromHours(kDefaultMaxDownloadAgeHours) +
-      base::TimeDelta::FromSeconds(1);
-  const base::Time outdated =
-      now - base::TimeDelta::FromHours(kDefaultMaxDownloadAgeHours) -
-      base::TimeDelta::FromSeconds(1);
+  const base::Time not_outdated = GetDummyNotOutdatedTime();
+  const base::Time outdated = GetDummyOutdatedTime();
 
   *(downloads_manager()->mutable_items()) = CreateDummyAssetDownloads({0, 1});
 
   downloads_manager()->mutable_items()->at(0)->SetURL(
       GURL("http://download.com/0"));
   downloads_manager()->mutable_items()->at(0)->SetStartTime(outdated);
   downloads_manager()->mutable_items()->at(0)->SetLastAccessTime(not_outdated);
 
   downloads_manager()->mutable_items()->at(1)->SetURL(
       GURL("http://download.com/1"));
   downloads_manager()->mutable_items()->at(1)->SetStartTime(outdated);
   downloads_manager()->mutable_items()->at(1)->SetLastAccessTime(
       downloads_manager()->mutable_items()->at(1)->GetStartTime());
 
   // Even though asset download 0 was downloaded long time ago, it should be
   // reported because it has been visited recently.
   EXPECT_CALL(
       *observer(),
       OnNewSuggestions(_, downloads_category(),
                        UnorderedElementsAre(HasUrl("http://download.com/0"))));
   auto test_clock = base::MakeUnique<base::SimpleTestClock>();
   test_clock->SetNow(now);
   CreateLoadedProvider(/*show_assets=*/true, /*show_offline_pages=*/false,
                        std::move(test_clock));
 }