Initial proto for language detection.

components/sync/protocol/user_event_specifics.proto

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Sync protocol datatype extension for user events.
 
 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
 // any fields in this file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package sync_pb;
 
+// Language detection output

[napper, 2017/05/18 04:55:06]

Add . to comment

[renjieliu1, 2017/05/18 05:48:21]

Done.

+message LanguageDetection {
+  message Language {
+    optional string language_code = 1;

[napper, 2017/05/18 04:55:06]

Can you add a comment as to what language code format is used?

[renjieliu1, 2017/05/18 05:48:21]

Done.

+    optional int32 percent = 2;

[napper, 2017/05/18 04:55:06]

int8?

[renjieliu1, 2017/05/18 05:48:21]

int32 is the minimum we can get for proto buffer :(

+  }

[napper, 2017/05/18 04:55:06]

Add a comment describing what percent is. Also percent doesnt seem like a very
clear name.

[renjieliu1, 2017/05/18 05:48:21]

how about proportion?

+  // Top n languages. Typically we just log the top one language, but for

[napper, 2017/05/18 04:55:07]

Change to "Typically we just log the top language"

[renjieliu1, 2017/05/18 05:48:21]

Done.

+  // page that we're not confident, we may log up to 3 top languages.

[napper, 2017/05/18 04:55:06]

"a page we are not confidence about,"

[renjieliu1, 2017/05/18 05:48:21]

Done.

+  repeated Language languages = 1;

[napper, 2017/05/18 04:55:06]

Would detected_languages be a better name here?

[renjieliu1, 2017/05/18 05:48:21]

sounds good :)

+  optional string adopted_language = 2;
+}
+
 message FieldTrialEvent {
   message FieldTrial {
     optional fixed32 name_id = 1;
     optional fixed32 group_id = 2;
   }
   repeated FieldTrial field_trials = 1;
 }
 
 message UserEventSpecifics {
   // Time of event, as measured on the client (unix epoch).
   optional int64 event_time_usec = 1;
 
   // The |global_id| field of the associated navigation, if there is one.
   optional int64 navigation_id = 2;
 
   // On startup we generate a new random id to identify which FieldTrialEvents
   // other events belonged to.
   optional fixed64 session_id = 3;
 
-  oneof event { FieldTrialEvent field_trial_event = 4; }
+  oneof event {
+    FieldTrialEvent field_trial_event = 4;
+    LanguageDetection translate_language_detection = 5;
+  }
 }