Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc

Issue 2892443002: [GRC] Process Coordination Unit support for Global Resource Controller (Closed)
Patch Set: Address CL review feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc
diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc b/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc
index 4640865e2e686b05be4f2182c39e527a82ffd5fb..b33736fd9428a64fa5a672b1c14fddaf5cde1d3f 100644
--- a/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc
+++ b/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc
@@ -8,6 +8,7 @@
#include "base/bind.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
+#include "services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest_util.h"
#include "services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h"
#include "services/service_manager/public/cpp/service_context_ref.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -16,30 +17,7 @@ namespace resource_coordinator {
namespace {
-void OnLastServiceRefDestroyed() {
- // No-op. This is required by service_manager::ServiceContextRefFactory
- // construction but not needed for the tests.
-}
-
-class CoordinationUnitImplTest : public testing::Test {
- public:
- CoordinationUnitImplTest()
- : service_ref_factory_(base::Bind(&OnLastServiceRefDestroyed)),
- provider_(&service_ref_factory_) {}
- ~CoordinationUnitImplTest() override {}
-
- // testing::Test:
- void TearDown() override { base::RunLoop().RunUntilIdle(); }
-
- protected:
- CoordinationUnitProviderImpl* provider() { return &provider_; }
-
- private:
- base::MessageLoop message_loop_;
-
- service_manager::ServiceContextRefFactory service_ref_factory_;
- CoordinationUnitProviderImpl provider_;
-};
+class CoordinationUnitImplTest : public CoordinationUnitImplTestBase {};
class TestCoordinationUnit : public mojom::CoordinationPolicyCallback {
public:

Powered by Google App Engine
This is Rietveld 408576698