[GRC] Process Coordination Unit support for Global Resource Controller

services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/process/process_handle.h"
+#include "base/run_loop.h"
+#include "services/resource_coordinator/coordination_unit/coordination_unit_factory.h"
+#include "services/resource_coordinator/coordination_unit/coordination_unit_impl.h"
+#include "services/resource_coordinator/coordination_unit/coordination_unit_impl_base_test_unittest.h"
+#include "services/resource_coordinator/public/cpp/coordination_unit_id.h"
+#include "services/resource_coordinator/public/cpp/coordination_unit_types.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace resource_coordinator {
+
+namespace {
+
+class ProcessCoordinationUnitImplTest : public CoordinationUnitImplBaseTest {};
+
+}  // namespace
+
+TEST_F(ProcessCoordinationUnitImplTest, MeasureCPUUsage) {
+  base::ProcessHandle current_pid = base::GetCurrentProcessHandle();
+  CoordinationUnitID cu_id(CoordinationUnitType::kProcess, current_pid);
+
+  std::unique_ptr<CoordinationUnitImpl> coordination_unit_ =
+      CoordinationUnitFactory::CreateCoordinationUnit(
+          cu_id, ServiceContextRefFactory());

[oystein (OOO til 10th of July), 2017/05/17 23:06:07]

Do we know what happens to the created ServiceContextRefs stored in the
CoordinationUnitImpls after the ServiceContextRefFactory gets destroyed after
this call? (I honestly don't know; I'd double-check or make it a member of
ProcessCoordinationUnitImplTest).

[matthalp, 2017/05/18 16:13:46]

Maybe I am misunderstanding, but I think this has already been taken care of
since it service_ref_ is already a member of the CoordinationUnitImpl that
ProcessCoordinationUnitImpl is derived from.

[oystein (OOO til 10th of July), 2017/05/18 21:24:32]

Yeah but it's being created from the ServiceContextRefFactory that dies right
after this call, i.e. the service_ref_ outlives the factory. Note:  haven't
looked into whether this is actually a problem or not, but I would guess that
service_ref_ would call back into the factory when it gets destructed?

+
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_LE(0.0, coordination_unit_->GetCPUUsageForTesting());

[oystein (OOO til 10th of July), 2017/05/17 23:06:07]

Shouldn't this be EXPECT_GE?

[matthalp, 2017/05/18 16:13:46]

EXPECT_LE(val1, val2) verifies val1 <= val2 [1] and we want to ensure CPU
utilization is non-negative.

[1] https://github.com/google/googletest/blob/master/googletest/docs/Primer.md

[oystein (OOO til 10th of July), 2017/05/18 21:24:32]

Makes sense!

+}
+
+}  // namespace resource_coordinator