[GRC] Process Coordination Unit support for Global Resource Controller

services/resource_coordinator/coordination_unit/coordination_unit_impl_base_test_unittest.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_RESOURCE_COORDINATOR_COORDINATION_UNIT_COORDINATION_UNIT_BASE_TEST_UNITTEST_H_

[oystein (OOO til 10th of July), 2017/05/17 23:06:06]

The name is a little confusing; maybe coordination_unit_impl_unittest_util.h
instead, that's a name pattern I've seen elsewhere for these kinds of helper
classes.

[matthalp, 2017/05/18 16:13:45]

Done.

+#define SERVICES_RESOURCE_COORDINATOR_COORDINATION_UNIT_COORDINATION_UNIT_BASE_TEST_UNITTEST_H_
+
+#include "base/message_loop/message_loop.h"
+#include "services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h"
+#include "services/service_manager/public/cpp/service_context_ref.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace resource_coordinator {
+
+class CoordinationUnitImplBaseTest : public testing::Test {

[oystein (OOO til 10th of July), 2017/05/17 23:06:06]

bikeshedding naming nit: CoordinationUnitImplTestBase instead maybe, since it's
a base for testing classes, not a test class for the base class?

[matthalp, 2017/05/18 16:13:45]

Done.

+ public:
+  CoordinationUnitImplBaseTest();
+  ~CoordinationUnitImplBaseTest() override {}

[oystein (OOO til 10th of July), 2017/05/17 23:06:06]

put the destructor body in the .cc, since it's a non-trivial destructor (and =
default; instead of {}).

[matthalp, 2017/05/18 16:13:45]

Done.

+
+  // testing::Test:
+  void TearDown() override;
+
+ protected:
+  service_manager::ServiceContextRefFactory* ServiceContextRefFactory() {

[oystein (OOO til 10th of July), 2017/05/17 23:06:06]

service_context_ref_factory() since it's a simple inlined getter function.

[matthalp, 2017/05/18 16:13:45]

Done.

+    return &service_ref_factory_;
+  }
+  CoordinationUnitProviderImpl* provider() { return &provider_; }
+
+ private:
+  base::MessageLoop message_loop_;
+  service_manager::ServiceContextRefFactory service_ref_factory_;
+  CoordinationUnitProviderImpl provider_;
+};
+
+}  // namespace resource_coordinator
+
+#endif  // SERVICES_RESOURCE_COORDINATOR_COORDINATION_UNIT_COORDINATION_UNIT_BASE_TEST_UNITTEST_H_