[GRC] Process Coordination Unit support for Global Resource Controller

services/resource_coordinator/coordination_unit/coordination_unit_factory.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_RESOURCE_COORDINATOR_COORDINATION_UNIT_COORDINATION_UNIT_FACTORY_H_
+#define SERVICES_RESOURCE_COORDINATOR_COORDINATION_UNIT_COORDINATION_UNIT_FACTORY_H_
+
+#include "services/resource_coordinator/coordination_unit/coordination_unit_impl.h"
+
+namespace service_manager {
+

[oystein (OOO til 10th of July), 2017/05/17 23:06:06]

nit: remove blank line

[matthalp, 2017/05/18 16:13:45]

Done.

+class ServiceContextRefFactory;
+

[oystein (OOO til 10th of July), 2017/05/17 23:06:06]

nit: remove blank line

[matthalp, 2017/05/18 16:13:45]

Done.

+}  // service_manager

[oystein (OOO til 10th of July), 2017/05/17 23:06:05]

no need for the // service_manager comment when you're just using namespaces for
forward declarations.

[matthalp, 2017/05/18 16:13:45]

Done.

+
+namespace resource_coordinator {
+
+struct CoordinationUnitID;
+
+class CoordinationUnitFactory {

[oystein (OOO til 10th of July), 2017/05/17 23:06:05]

Since we're wrapped in a namespace here anyway and just have a single static
function, I wouldn't bother with the class at all (though a nested
CoordinationUnitFactory namespace is probably good, to keep the naming still).

[matthalp, 2017/05/18 16:13:45]

Done.

+ public:
+  static std::unique_ptr<CoordinationUnitImpl> CreateCoordinationUnit(
+      const CoordinationUnitID& id,
+      service_manager::ServiceContextRefFactory* service_ref_factory);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(CoordinationUnitFactory);

[oystein (OOO til 10th of July), 2017/05/17 23:06:05]

nit: should include "base/macros.h" for this, for completeness. Same with
<memory> for the unique_ptr usage (i.e. shouldn't rely on the indirect headers
from coordination_unit_impl.h.

[matthalp, 2017/05/18 16:13:45]

N/A since this is no longer a class as the code is now a namespaced function.

+};
+
+}  // namespace resource_coordinator
+
+#endif  // SERVICES_RESOURCE_COORDINATOR_COORDINATION_UNIT_COORDINATION_UNIT_FACTORY_H_