Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2892413002: Fix ARMv6 Linux cross-build (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Hixie
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add an argument to specifiy the float ABI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 5 chunks +1 line, -12 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn.py View 1 3 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zra
3 years, 7 months ago (2017-05-22 03:25:11 UTC) #2
rmacnak
On 2017/05/22 03:25:11, zra wrote: I get a link error: /usr/local/google/home/rmacnak/cross/pi/tools/arm-bcm2708/gcc-linaro-arm-linux-gnueabihf-raspbian-x64/bin/../lib/gcc/arm-linux-gnueabihf/4.8.3/../../../../arm-linux-gnueabihf/bin/ld: error: ./process_test uses VFP ...
3 years, 7 months ago (2017-05-22 16:03:04 UTC) #3
zra
I've added a gn.py argument that allows specifying the float ABI. When using the hf ...
3 years, 7 months ago (2017-05-22 17:45:54 UTC) #4
rmacnak
lgtm
3 years, 7 months ago (2017-05-22 19:42:55 UTC) #5
zra
3 years, 7 months ago (2017-05-22 20:15:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
34f601a8dbd43ed5c9bdbace7a547769e4c03472 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698