Introduce lock screen app context to extension features

extensions/common/extension.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_EXTENSION_H_
 #define EXTENSIONS_COMMON_EXTENSION_H_
 
 #include <map>
 #include <memory>
 #include <set>
@@ skipping 139 matching lines @@
 
     // DEPRECATED: WAS_INSTALLED_BY_CUSTODIAN is now stored as a pref instead.
     // WAS_INSTALLED_BY_CUSTODIAN = 1 << 11,
 
     // |MAY_BE_UNTRUSTED| indicates that this extension came from a potentially
     // unsafe source (e.g., sideloaded from a local CRX file via the Windows
     // registry). Such extensions may be subjected to additional constraints
     // before they are fully installed and enabled.
     MAY_BE_UNTRUSTED = 1 << 12,
 
+    // |RUN_ON_LOCK_SCREEN| indicates that this extension will be run on lock
+    // screen. It's primarily set for lock screen action handler platform apps.
+    // The apps will be able to create a window on top of Chrome OS lock screen
+    // and will have resticted access to extension APIs. The apps will be
+    // installed in a browser context not associated with any user.
+    RUNS_ON_LOCK_SCREEN = 1 << 13,

[Devlin, 2017/05/23 16:51:53]

I'm not sure we want a creation flag for this, but it doesn't seem to be used
anywhere.  Is there a reason you wanted to take this approach?

[tbarzic, 2017/05/23 17:30:23]

I'll add code that uses the flag in later cls.

The reason for this approach is that it works with how apps will be set up for
handling actions on lock screen.
The app would be added to a profile not associated with any user (current plan
is to use sign-in profile), and when the app has to be launched, onLaunced
events would be sent to the app in that profile.
Given that the app instances would be designated to handle lock screen requests,
it makes sense  to make that a property of the app instance. And since
'runs_on_lock_screen' value would remain unchanged during the app's lifetime, I
figured to set this value as a creation flag.

basically the meaning of the flag would be "installed into lock-screen profile
with intent to handle actions on lock screen".

[Devlin, 2017/05/25 20:42:02]

Sorry for the delay.

I'd prefer we don't have this as a creation flag; it doesn't seem like quite the
right place for it.  My understanding is that the app will still be able to
communicate (in some way) with its non-lock-screen counterpart, and having
different, semi-transitive creation flags seems weird.

Out of curiosity, do we need to store a bit on the extension at all?  If we're
adding this to a lock screen profile, isn't the fact that it's added indicative
of it running on the lock screen?

+
     // When adding new flags, make sure to update kInitFromValueFlagBits.
   };
 
   // This is the highest bit index of the flags defined above.
   static const int kInitFromValueFlagBits;
 
   static scoped_refptr<Extension> Create(const base::FilePath& path,
                                          Manifest::Location location,
                                          const base::DictionaryValue& value,
                                          int flags,
@@ skipping 147 matching lines @@
   bool may_be_untrusted() const {
     return (creation_flags_ & MAY_BE_UNTRUSTED) != 0;
   }
   bool was_installed_by_default() const {
     return (creation_flags_ & WAS_INSTALLED_BY_DEFAULT) != 0;
   }
   bool was_installed_by_oem() const {
     return (creation_flags_ & WAS_INSTALLED_BY_OEM) != 0;
   }
 
+  bool runs_on_lock_screen() const {
+    return (creation_flags_ & RUNS_ON_LOCK_SCREEN) != 0;
+  }
+
   // Type-related queries. These are all mutually exclusive.
   //
   // The differences between the types of Extension are documented here:
   // https://chromium.googlesource.com/chromium/src/+/HEAD/extensions/docs/extension_and_app_types.md
   bool is_platform_app() const;         // aka "V2 app", "V2 packaged app"
   bool is_hosted_app() const;           // Hosted app (or bookmark app)
   bool is_legacy_packaged_app() const;  // aka "V1 packaged app"
   bool is_extension() const;            // Regular browser extension, not an app
   bool is_shared_module() const;        // Shared module
   bool is_theme() const;                // Theme
@@ skipping 215 matching lines @@
   const PermissionSet& permissions;
 
   UpdatedExtensionPermissionsInfo(const Extension* extension,
                                   const PermissionSet& permissions,
                                   Reason reason);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_EXTENSION_H_