Introduce lock screen app context to extension features

extensions/browser/process_map.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/process_map.h"
 
 #include <tuple>
 
 #include "content/public/browser/child_process_security_policy.h"
 #include "extensions/browser/extension_registry.h"
@@ skipping 98 matching lines @@
        ++iter) {
     if (iter->process_id == process_id)
       result.insert(iter->extension_id);
   }
   return result;
 }
 
 Feature::Context ProcessMap::GetMostLikelyContextType(
     const Extension* extension,
     int process_id) const {
-  // WARNING: This logic must match Dispatcher::ClassifyJavaScriptContext, as
-  // much as possible.
+  // WARNING: This logic must match ScriptContextSet::ClassifyJavaScriptContext,
+  // as much as possible.
 
   if (content::ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings(
           process_id)) {
     return Feature::WEBUI_CONTEXT;
   }
 
   if (!extension) {
     return Feature::WEB_PAGE_CONTEXT;
   }
 
   if (!Contains(extension->id(), process_id)) {
     // This could equally be UNBLESSED_EXTENSION_CONTEXT, but we don't record
     // which processes have extension frames in them.
     // TODO(kalman): Investigate this.
     return Feature::CONTENT_SCRIPT_CONTEXT;
   }
 
   if (extension->is_hosted_app() &&
       extension->location() != Manifest::COMPONENT) {
     return Feature::BLESSED_WEB_PAGE_CONTEXT;
   }
 
-  return Feature::BLESSED_EXTENSION_CONTEXT;
+  return is_lock_screen_context_ ? Feature::LOCK_SCREEN_EXTENSION_CONTEXT

[Devlin, 2017/06/03 02:19:14]

If we expect no other lock-screen-type contexts, maybe it'd make sense to put
this at the top?

if (is_lock_screen_context_)
  return FEATURE::LOCK_SCREEN_CONTEXT;

if (content::ChildProcess....)

return Feature::BLESSED_EXTENSION_CONTEXT;

Because we *are* determining that any lock screen context is considered a lock
screen extension context, right?  Or are we anticipating having multiple
processes on the lock screen, some of which are "blessed" lock screen contexts,
and others that would be "web-page like" contexts?

[tbarzic, 2017/06/05 19:35:40]

At the moment, we could have web-page like contexts, in particular lock screen
UI is currently implemented as webui (though, that will probably change in near
future).

For content scripts/hosted apps, these should never be active for lock_screen
context, so it might be better to have a CHECK(!is_lock_screen_context_) or
return unspecified context instead of forcing LOCK_SCREEN_EXTENSION_CONTEXT.
WDYT?

+                                 : Feature::BLESSED_EXTENSION_CONTEXT;
 }
 
 }  // namespace extensions