third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h - Issue 2892393002: Move WebInputMethodControllerImpl to core/exported/ & break dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h

Issue 2892393002: Move WebInputMethodControllerImpl to core/exported/ & break dependencies. (Closed)

Patch Set: Move WebInputMethodControllerImpl to core/exported/ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/exported/BUILD.gn ('k') | third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h

diff --git a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h b/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h

similarity index 84%

rename from third_party/WebKit/Source/web/WebInputMethodControllerImpl.h

rename to third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h

index 8c4bf6b92168d1c0dae309e1e60a43086eef2782..fa0fd1f586004422af1b676eabdecfbe51400833 100644

--- a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h

+++ b/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h

@@ -5,6 +5,7 @@

#ifndef WebInputMethodControllerImpl_h

#define WebInputMethodControllerImpl_h

+#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

#include "public/web/WebCompositionUnderline.h"

#include "public/web/WebInputMethodController.h"

@@ -13,20 +14,19 @@ namespace blink {

class InputMethodController;

class LocalFrame;

-class WebLocalFrameImpl;

+class WebLocalFrameBase;

class WebPlugin;

class WebRange;

class WebString;

-class WebInputMethodControllerImpl : public WebInputMethodController {

+class CORE_EXPORT WebInputMethodControllerImpl

+ : public WebInputMethodController {

WTF_MAKE_NONCOPYABLE(WebInputMethodControllerImpl);

public:

- explicit WebInputMethodControllerImpl(WebLocalFrameImpl* owner_frame);

+ explicit WebInputMethodControllerImpl(WebLocalFrameBase* owner_frame);

~WebInputMethodControllerImpl() override;

- static WebInputMethodControllerImpl* FromFrame(LocalFrame*);

// WebInputMethodController overrides.

bool SetComposition(const WebString& text,

const WebVector<WebCompositionUnderline>& underlines,

@@ -49,7 +49,7 @@ class WebInputMethodControllerImpl : public WebInputMethodController {

InputMethodController& GetInputMethodController() const;

WebPlugin* FocusedPluginIfInputMethodSupported() const;

- WeakMember<WebLocalFrameImpl> web_local_frame_;

+ WeakMember<WebLocalFrameBase> web_local_frame_;

dcheng 2017/05/23 01:43:31 FYI, I just changed this in https://chromium-revie

};

} // namespace blink