Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: extensions/browser/user_script_loader.h

Issue 2892353002: WebUI: Fix crash while loading scripts for webview.[add/remove]ContentScripts API. (Closed)
Patch Set: Remove test and add TODO Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/web_ui_user_script_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/user_script_loader.h
diff --git a/extensions/browser/user_script_loader.h b/extensions/browser/user_script_loader.h
index a6a5d7c9ef23d0845026a8fa4cf6cf0f80ec6517..c09166296835a96ab5624577d257b88d5aa28d55 100644
--- a/extensions/browser/user_script_loader.h
+++ b/extensions/browser/user_script_loader.h
@@ -95,7 +95,8 @@ class UserScriptLoader : public content::NotificationObserver {
void RemoveObserver(Observer* observer);
protected:
- // Allows the derived classes have different ways to load user scripts.
+ // Allows the derived classes to have different ways to load user scripts.
+ // This may not be synchronous with the calls to Add/Remove/Clear scripts.
virtual void LoadScripts(std::unique_ptr<UserScriptList> user_scripts,
const std::set<HostID>& changed_hosts,
const std::set<int>& added_script_ids,
« no previous file with comments | « no previous file | extensions/browser/web_ui_user_script_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698