Issue 28923005: [android_webview] Fix crash in testCreateDestroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28923005: [android_webview] Fix crash in testCreateDestroy. (Closed)

Created:
7 years, 2 months ago by mkosiba (inactive)

Modified:
7 years, 2 months ago

Reviewers:
mnaganov (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[android_webview] Fix crash in testCreateDestroy. The onSizeChanged callback was arriving after the AwContents was destroyed. Ignoring the setFixedLayoutSize call is fine since the AwContents is going away anyway. BUG=308497 R=mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229798

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/28923005/1

7 years, 2 months ago (2013-10-18 16:54:53 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 2 months ago (2013-10-18 18:13:06 UTC) #4

mkosiba (inactive)

7 years, 2 months ago (2013-10-21 13:39:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r229798 (presubmit successful).