Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: Source/devtools/front_end/ConsoleView.js

Issue 28923003: DevTools: console.table attached inside a collapsed console group is not resizeable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1209 matching lines...) Expand 10 before | Expand all | Expand 10 after
1220 1220
1221 if (element.previousSibling && message.originatingCommand && element.pre viousSibling.command === message.originatingCommand) 1221 if (element.previousSibling && message.originatingCommand && element.pre viousSibling.command === message.originatingCommand)
1222 element.previousSibling.addStyleClass("console-adjacent-user-command -result"); 1222 element.previousSibling.addStyleClass("console-adjacent-user-command -result");
1223 }, 1223 },
1224 1224
1225 _titleClicked: function(event) 1225 _titleClicked: function(event)
1226 { 1226 {
1227 var groupTitleElement = event.target.enclosingNodeOrSelfWithClass("conso le-group-title"); 1227 var groupTitleElement = event.target.enclosingNodeOrSelfWithClass("conso le-group-title");
1228 if (groupTitleElement) { 1228 if (groupTitleElement) {
1229 var groupElement = groupTitleElement.enclosingNodeOrSelfWithClass("c onsole-group"); 1229 var groupElement = groupTitleElement.enclosingNodeOrSelfWithClass("c onsole-group");
1230 if (groupElement) 1230 if (groupElement && !groupElement.classList.toggle("collapsed")) {
1231 if (groupElement.hasStyleClass("collapsed")) 1231 if (groupElement.group) {
1232 groupElement.removeStyleClass("collapsed"); 1232 groupElement.group.wasShown();
1233 else 1233 }
1234 groupElement.addStyleClass("collapsed"); 1234 }
1235 groupTitleElement.scrollIntoViewIfNeeded(true); 1235 groupTitleElement.scrollIntoViewIfNeeded(true);
1236 } 1236 }
1237 event.consume(true);
1238 },
1237 1239
1238 event.consume(true); 1240 wasShown: function()
1241 {
1242 if (this.element.hasStyleClass("collapsed"))
1243 return;
1244 var node = this.messagesElement.firstChild;
1245 while (node) {
1246 if (node.hasStyleClass("console-message") && node.message)
1247 node.message.wasShown();
1248 if (node.hasStyleClass("console-group") && node.group)
1249 node.group.wasShown();
1250 node = node.nextSibling;
1251 }
1239 } 1252 }
1240 } 1253 }
1241 1254
1242 /** 1255 /**
1243 * @type {?WebInspector.ConsoleView} 1256 * @type {?WebInspector.ConsoleView}
1244 */ 1257 */
1245 WebInspector.consoleView = null; 1258 WebInspector.consoleView = null;
1246 1259
1247 WebInspector.ConsoleMessage.create = function(source, level, message, type, url, line, column, repeatCount, parameters, stackTrace, requestId, isOutdated) 1260 WebInspector.ConsoleMessage.create = function(source, level, message, type, url, line, column, repeatCount, parameters, stackTrace, requestId, isOutdated)
1248 { 1261 {
1249 return new WebInspector.ConsoleMessageImpl(source, level, message, WebInspec tor.consoleView._linkifier, type, url, line, column, repeatCount, parameters, st ackTrace, requestId, isOutdated); 1262 return new WebInspector.ConsoleMessageImpl(source, level, message, WebInspec tor.consoleView._linkifier, type, url, line, column, repeatCount, parameters, st ackTrace, requestId, isOutdated);
1250 } 1263 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698