Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: base/trace_event/heap_profiler_allocation_context.h

Issue 2892273003: Produce more useful stack traces for heap profiling. (Closed)
Patch Set: Comments from dskiba. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/heap_profiler_allocation_context_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/heap_profiler_allocation_context.h
diff --git a/base/trace_event/heap_profiler_allocation_context.h b/base/trace_event/heap_profiler_allocation_context.h
index 3d8053c9fb31ea3941155d662fcdacfd8e7fe47e..5173eefb3e3689ded124bead115c842b9f3d436b 100644
--- a/base/trace_event/heap_profiler_allocation_context.h
+++ b/base/trace_event/heap_profiler_allocation_context.h
@@ -69,8 +69,8 @@ bool BASE_EXPORT operator != (const StackFrame& lhs, const StackFrame& rhs);
struct BASE_EXPORT Backtrace {
Backtrace();
- // If the stack is higher than what can be stored here, the bottom frames
- // (the ones closer to main()) are stored. Depth of 12 is enough for most
+ // If the stack is higher than what can be stored here, the top frames
+ // (the ones further from main()) are stored. Depth of 12 is enough for most
// pseudo traces (see above), but not for native traces, where we need more.
enum { kMaxFrameCount = 48 };
StackFrame frames[kMaxFrameCount];
« no previous file with comments | « no previous file | base/trace_event/heap_profiler_allocation_context_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698