Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2892223002: Fuchsia SDK: Also copy zlib to the SDK's bin directory (Closed)

Created:
3 years, 7 months ago by rmacnak
Modified:
3 years, 7 months ago
Reviewers:
jamesr1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia SDK: Also copy zlib to the SDK's bin directory. So we run with the one built in the Fuchsia tree instead of the (potentially absent) one from the host. R=jamesr@google.com Committed: https://github.com/dart-lang/sdk/commit/1a5571904d631c43e3e1ae145daa09677eb3e552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sdk/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
3 years, 7 months ago (2017-05-19 18:21:55 UTC) #3
jamesr1
lgtm
3 years, 7 months ago (2017-05-19 18:55:02 UTC) #4
rmacnak
3 years, 7 months ago (2017-05-19 20:23:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a5571904d631c43e3e1ae145daa09677eb3e552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698